From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14263 invoked by alias); 14 Aug 2014 13:48:08 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 14253 invoked by uid 89); 14 Aug 2014 13:48:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 14 Aug 2014 13:48:05 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 134DA11631C; Thu, 14 Aug 2014 09:48:04 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id bGqX6btO7xfd; Thu, 14 Aug 2014 09:48:04 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D0D631162ED; Thu, 14 Aug 2014 09:48:03 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A7BE6493CB; Thu, 14 Aug 2014 06:48:07 -0700 (PDT) Date: Thu, 14 Aug 2014 13:48:00 -0000 From: Joel Brobecker To: Andreas Schwab Cc: Gary Benson , Mike Frysinger , gdb@sourceware.org, Andreas Arnez Subject: Re: ChangeLogs in commit messages Message-ID: <20140814134807.GI4924@adacore.com> References: <20140814083231.GA6283@blade.nx> <6036430.RnprRWgZmF@vapier> <20140814131206.GA12746@blade.nx> <20140814132939.GH4924@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-08/txt/msg00028.txt.bz2 > > No, I strongly object to #5. The ChangeLog entries are part of > > the email to be sent along with the patch to be reviewed, We had > > that discussion many many years ago, and at the time, people > > wanted the CL entry in the email, rather than as a diff. > > How does this have anything to do with the commit message? The email can be sent nearly verbatim using "git send-email". This is an objective that can be achieved with zero extra work if you consider the other reasons I gave why I think the CL entry should be in the revision log. -- Joel