From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14388 invoked by alias); 14 Aug 2014 12:52:24 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 14379 invoked by uid 89); 14 Aug 2014 12:52:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 14 Aug 2014 12:52:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CC57F11627A; Thu, 14 Aug 2014 08:52:20 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id cpsPdi0v8Gak; Thu, 14 Aug 2014 08:52:20 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 92575116273; Thu, 14 Aug 2014 08:52:20 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 332B3493BB; Thu, 14 Aug 2014 05:52:24 -0700 (PDT) Date: Thu, 14 Aug 2014 12:52:00 -0000 From: Joel Brobecker To: Gary Benson Cc: gdb@sourceware.org, Andreas Arnez Subject: Re: ChangeLogs in commit messages Message-ID: <20140814125224.GF4924@adacore.com> References: <20140814083231.GA6283@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140814083231.GA6283@blade.nx> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-08/txt/msg00019.txt.bz2 > 1. With paths and with the date-and-author header: > > gdb/ > 2014-07-30 Gary Benson > > * btrace.c: Include defs.h. > * common/ptid.c: Include defs.h or server.h as appropriate. > * nat/mips-linux-watch.c: Likewise. > > 2. With date-and-author headers but no paths: > > 2014-08-04 Tom Tromey > > * gdb.base/sss-bp-on-user-bp-2.exp: Match "to_resume", not > "target_resume". > > 3. With paths but no date-and-author headers: > > gdb/ChangeLog: > > * amd64-windows-tdep.c (amd64_windows_frame_decode_insns): > Add debug trace. > > 4. With no preamble at all: > > * chew.c (print_stack_level, main): Cast result of pointer > difference to match format string. > > What are people's preferences here? My preference is #1, but I could > live with #3. If we come to some kind of concensus on this I'll > update the wiki to reflect this. #3, since date and author are often redundant with the commit's author. And even if not in the same, it's in the ChangeLog entry that should be checked in as part of the commit. Also, I feel like having those in the CL is an extra source of potential issue (eg: if forgot to update the date), and revision logs cannot be fixed once the commit has been pushed, whereas dates in ChangeLog entries can. But I can also live with #1. Not super keen on #2 and #4 in the sense that it seems important to me to say which ChangeLogs are being updated, since filenames are relative to those. I do think we can be a little flexible without much downside, and therefore have a set of accepted practices. -- Joel