From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32084 invoked by alias); 14 Aug 2014 08:32:39 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 32068 invoked by uid 89); 14 Aug 2014 08:32:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 14 Aug 2014 08:32:37 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7E8WXLR024721 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Aug 2014 04:32:33 -0400 Received: from blade.nx (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7E8WXL3007732; Thu, 14 Aug 2014 04:32:33 -0400 Received: by blade.nx (Postfix, from userid 1000) id 677F32640E7; Thu, 14 Aug 2014 09:32:31 +0100 (BST) Date: Thu, 14 Aug 2014 08:32:00 -0000 From: Gary Benson To: gdb@sourceware.org Cc: Andreas Arnez Subject: ChangeLogs in commit messages Message-ID: <20140814083231.GA6283@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00018.txt.bz2 Hi all, I recently added an extra section to the contributions checklist on the wiki documenting the conversation on commit messages from when we switched to git: https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages Andreas pointed out that different people are including the ChangeLog entries in different ways, 1. With paths and with the date-and-author header: gdb/ 2014-07-30 Gary Benson * btrace.c: Include defs.h. * common/ptid.c: Include defs.h or server.h as appropriate. * nat/mips-linux-watch.c: Likewise. 2. With date-and-author headers but no paths: 2014-08-04 Tom Tromey * gdb.base/sss-bp-on-user-bp-2.exp: Match "to_resume", not "target_resume". 3. With paths but no date-and-author headers: gdb/ChangeLog: * amd64-windows-tdep.c (amd64_windows_frame_decode_insns): Add debug trace. 4. With no preamble at all: * chew.c (print_stack_level, main): Cast result of pointer difference to match format string. What are people's preferences here? My preference is #1, but I could live with #3. If we come to some kind of concensus on this I'll update the wiki to reflect this. Thanks, Gary -- http://gbenson.net/