Re: Patchwork patch tracking system

Pedro Alves
2014-05-21T21:35:18Z

On 05/21/2014 07:03 PM, Eli Zaretskii wrote:
>> Date: Wed, 21 May 2014 18:18:06 +0100
>> From: Pedro Alves <palves@redhat.com>
>> CC: Gary Benson <gbenson@redhat.com>, Stan Shebs <stanshebs@earthlink.net>, gdb@sourceware.org
>>
>> The fact that the ChangeLog is usually not a part of the patch
>> and then is added before push changes the hash.
>
> But that's just for historical reasons, right? If we use
> git-changelog-merge, there should be no reason not to make ChangeLog
> changes part of the patch, right?

Right, but still, but if that merge actually changes the patch,
because it puts the ChangeLog entry at the top of the file, and
the top commit is no longer the same as was when the patch was
generated for submission (frequently true), then the hash changes.

--
Pedro Alves