From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25459 invoked by alias); 9 Jan 2014 14:57:40 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 25448 invoked by uid 89); 9 Jan 2014 14:57:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2014 14:57:37 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s09EvamD023209 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 Jan 2014 09:57:36 -0500 Received: from localhost.localdomain (ovpn-112-29.ams2.redhat.com [10.36.112.29]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s09EvWm1008579 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Thu, 9 Jan 2014 09:57:35 -0500 Date: Thu, 09 Jan 2014 14:57:00 -0000 From: Phil Muldoon To: gdb@sourceware.org Subject: Re: Trailing Whitespace Message-ID: <20140109145731.GA13720@localhost.localdomain> Reply-To: pmuldoon@redhat.com References: <20140109144455.GA2972@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140109144455.GA2972@blade.nx> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00008.txt.bz2 On Thu, 09 Jan 2014, Gary Benson wrote: > Ben Longbons wrote: > > Therefore, I suggest that someone create a commit that removes all > > the trailing whitespace. The pressing need is to apply this to gdb/ > > but there is no reason it couldn't be applied to other parts if need > > be. > I see nobody replied to this, but it would be pretty nice to have the > repo cleaned in this way. > > Does anybody have any reason not to do this? Whitespace cleanups inevitably bit-rot unless the maintainer checks each and every patch for whitespace. This is pretty easy to do in emacs, but I am not so sure about other editors. It's another weight on the already burdened shoulders of maintainers. The simple way to make sure that your patch does not have useless whitespace included is to run: git diff --check That will flag all the whitespace. Also (and I am not sure if git can get around this somehow) whitespace cleanups tend to obliterate diffs/patches that were written before the cleanup took place. This makes merging a massive pain. So my 2 pence worth is, no, not a good idea ;) Cheers, Phil