From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2425 invoked by alias); 30 Oct 2013 00:37:29 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 2395 invoked by uid 89); 30 Oct 2013 00:37:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pd0-f171.google.com Received: from mail-pd0-f171.google.com (HELO mail-pd0-f171.google.com) (209.85.192.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 30 Oct 2013 00:37:27 +0000 Received: by mail-pd0-f171.google.com with SMTP id w10so185635pde.30 for ; Tue, 29 Oct 2013 17:37:25 -0700 (PDT) X-Received: by 10.66.141.73 with SMTP id rm9mr180333pab.167.1383093444727; Tue, 29 Oct 2013 17:37:24 -0700 (PDT) Received: from bubble.grove.modra.org ([101.166.26.37]) by mx.google.com with ESMTPSA id iu7sm37541895pbc.45.2013.10.29.17.37.22 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 29 Oct 2013 17:37:23 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 909EAEA006C; Wed, 30 Oct 2013 11:07:19 +1030 (CST) Date: Wed, 30 Oct 2013 00:37:00 -0000 From: Alan Modra To: Tom Tromey , GDB Development , Binutils Development Subject: Re: git is live Message-ID: <20131030003719.GB20756@bubble.grove.modra.org> Mail-Followup-To: Tom Tromey , GDB Development , Binutils Development References: <877gd5iyaz.fsf@fleche.redhat.com> <20131029222332.GZ20756@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131029222332.GZ20756@bubble.grove.modra.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-10/txt/msg00188.txt.bz2 On Wed, Oct 30, 2013 at 08:53:32AM +1030, Alan Modra wrote: > I tried to push some testsuite changes today, and got > > remote: ld/testsuite/ld-powerpc/tlsexe.r:50: trailing whitespace. > remote: + +03 +\.tdata \.dynamic \.opd \.got \.plt > remote: ld/testsuite/ld-powerpc/tlsexe.r:90: trailing whitespace. > remote: +.* SECTION +LOCAL +DEFAULT +13 > ... > remote: error: hook declined to update refs/heads/master > > I agree that it's good to reject trailing whitespace generally, but > the testsuite is a little special. We're matching tool output. If, > as in this example, readelf emits trailing whitespace then we > shouldn't need to write a regex to match it. Can this be fixed > easily? Come to think of it, maybe no trailing whitespace in the testsuite isn't such a bad thing. If the testsuite matched all trailing spaces with " *" then the bar to updating readelf and objdump -d to not emit trailing spaces is that much lower. -- Alan Modra Australia Development Lab, IBM