Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: asmwarrior <asmwarrior@gmail.com>
Cc: gdb@sourceware.org
Subject: Re: suggestion: the title of mails in the cvs mailllist should show the changed location instead a hash value
Date: Fri, 25 Oct 2013 01:56:00 -0000	[thread overview]
Message-ID: <20131025015603.GK4688@adacore.com> (raw)
In-Reply-To: <5269B846.3090301@gmail.com>

> Hi, after the git migration, I see that the email title changed in the cvs maillist like:
> 
> gdb and binutils branch master updated. 5c2955e2ec5ca2e80098763d6fdda317dc4b2f39
> gdb and binutils branch master updated. 7283b932234f3501eb19c1750d79c20fc339f32a
> ...
> 
> 
> Compared to the original name before git migration:
> src/gdb ChangeLog infrun.c testsuite/ChangeLog ...
> src/gdb ChangeLog c-varobj.c
> 
> 
> I think the old style email title is still better than the current one, it at least showed some changed files/locations, so a reader(like me, I use the news://www.gmane.org:119/gmane.comp.gdb.cvs to receive the updated emails) can briefly see where the commit modifies by reading the title. With the current name scheme, you know nothing about this.
> 
> Any ideas?

True, but eventually, I think an even better approach is to have one
email per commit, with the commit's subject as the email subject.
It's something I have implemented at AdaCore for our internal git
repositories, and works pretty well. I'd be happy to help improve
the hooks, but it'll have to be sometime next year.

In the meantime, I think I see in the script where we could change
the subject to add the list of files being changed. It should be
fairly easy to do so, but we'd need to agree on the new format.
For instance:

    '[' project ['/' branch] ']' updated-files

Eg:

    [gdb] gdb/infrun.c gdb/ChangeLog  <-- update of the master branch

    [gdb/gdb-7.7] gdb/NEWS gdb/ChangeLog  <-- update of the gdb-7.7 branch

For pure binutils changes, you'd get the same, but replacing "gdb"
by "binutils".

And for changes spanning both projects, you'd get:

    [gdb+binutils] bfd/configure.host bfd/ChangeLog gdb/ChangeLog
    [gdb+binutils/gdb-7.7] bfd/configure.host bfd/ChangeLog gdb/ChangeLog

-- 
Joel


      reply	other threads:[~2013-10-25  1:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-25  0:08 asmwarrior
2013-10-25  1:56 ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131025015603.GK4688@adacore.com \
    --to=brobecker@adacore.com \
    --cc=asmwarrior@gmail.com \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox