From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25322 invoked by alias); 4 Aug 2013 19:33:40 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 25291 invoked by uid 89); 4 Aug 2013 19:33:38 -0000 X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 04 Aug 2013 19:33:37 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r74JXSj8005561 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 4 Aug 2013 15:33:28 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r74JXNih005996 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 4 Aug 2013 15:33:26 -0400 Date: Sun, 04 Aug 2013 19:33:00 -0000 From: Jan Kratochvil To: Keven Boell Cc: "Agovic, Sanimir" , "gdb@sourceware.org" , "Boell, Keven" Subject: Re: Variable Length Arrays (VLA) proposal Message-ID: <20130804193323.GB31353@host2.jankratochvil.net> References: <0377C58828D86C4588AEEC42FC3B85A7176288F9@IRSMSX105.ger.corp.intel.com> <20130702133712.GA17311@host2.jankratochvil.net> <51D56B47.9030506@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51D56B47.9030506@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-08/txt/msg00006.txt.bz2 On Thu, 04 Jul 2013 14:32:07 +0200, Keven Boell wrote: > We've created some tests for the VLA features in Fortran and C in > advance to test our future implementation against it. We used/split > some of your tests from archer-jankratochvil-vla and added some more > to cover more VLA use-cases, we want to fix/enable in GDB. Maybe you > can have a look at them to see if we agree on the feature set in > general, which will be available to the user afterwards. > > You can find them in our github repository (see the last few commits): > https://github.com/ChristophTWeinmann/GDB/tree/vla-testbase GIT URL: https://github.com/ChristophTWeinmann/GDB.git > The tests are covering only Fortran and C at the moment. Some of the files need CRLF->LF conversion. > gdb/testsuite/gdb.base/vla-datatypes.exp > gdb/testsuite/gdb.base/vla-multi.exp > gdb/testsuite/gdb.base/vla-ptr.exp > gdb/testsuite/gdb.fortran/vla-alloc-assoc.exp > gdb/testsuite/gdb.fortran/vla-datatypes.exp type = long [5] (gdb) FAIL: gdb.base/vla-datatypes.exp: ptype long_vla Expected "long int [5]", I use gcc-4.8.1-5.fc20.x86_64. Such minor differences for different compilers are OK and common in GDB testsuite. > gdb/testsuite/gdb.fortran/vla-func.exp > gdb/testsuite/gdb.fortran/vla-ptype-sub.exp > gdb/testsuite/gdb.fortran/vla-ptype.exp > gdb/testsuite/gdb.fortran/vla-type.exp archer-jankratochvil-vla has some FAILs here for more compilated types, that is a known bug of archer-jankratochvil-vla. gdb.fortran/vla-value.exp Why isn't prepare_for_testing used here? gdb.fortran/vla.f90 Missing copyright header. I did not check it but I guess these testcases / expect strings work only with gfortran. If you are interested it would be sure great if they worked also with iFort. In general expect strings in testcases "\\$\\d+ = ..." are commonly simplified to " = ..." (start of expect strings are not anchored by ^ even in gdb_test). But it is up to the submitter, "\\$\\d+ = ..." is also fine. In general 'untested' call is not needed after failed prepare_for_testing. The same applies to failed 'runto MAIN__'. The testcases are pre-approved for check-in. But you will also need to write stub (just "*: New files." for everything) ChangeLog entry and post it to gdb-patches. And if you like to check them in before the real VLA implementation they would need KFAILs for everything (IMO not worth the work to check in the testcases before the implementation). Thanks, Jan