Re: New GDB 7.5.x release sometime next week?

[Joel Brobecker <brobecker@adacore.com>]

> Subject: [PATCH] libiberty/md5: fix strict alias warnings
> 
> Current libiberty md5 code triggers these warnings with gcc-4.7.1 for me:
> 
> libiberty/md5.c: In function 'md5_finish_ctx':
> libiberty/md5.c:117:3: warning: dereferencing type-punned pointer will break 
> strict-aliasing rules [-Wstrict-aliasing]
> libiberty/md5.c:118:3: warning: dereferencing type-punned pointer will break 
> strict-aliasing rules [-Wstrict-aliasing]
> 
> The change below fixes things for me.  The optimized output (-O2) is
> the same before/after my change on x86_64-linux.  I imagine it'll be
> the same for most targets.  It seems simpler than using a union on the
> md5_ctx buffer since these are the only two locations in the code
> where this occurs.

I am on the fence regarding this change. On the one hand, it seems
hardly critical, since it only fixes some warnings, and does not seem
to cause any improvement in the actual code generated. On the other
hand, this module appears to be completely unused in all of GDB (?).
So the risk would be small. For that reason, and the fact that the code
has been in since end of July, I think it's OK to include it, and
avoid the warnings.

Thanks,
-- 
Joel