From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13691 invoked by alias); 27 Nov 2012 21:38:35 -0000 Received: (qmail 13469 invoked by uid 22791); 27 Nov 2012 21:38:30 -0000 X-SWARE-Spam-Status: No, hits=-9.0 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Nov 2012 21:38:25 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 9D01933D7E4; Tue, 27 Nov 2012 21:38:24 +0000 (UTC) From: Mike Frysinger To: Joel Brobecker Subject: Re: New GDB 7.5.x release sometime next week? Date: Tue, 27 Nov 2012 21:38:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.6.5; KDE/4.6.5; x86_64; ; ) Cc: gdb@sourceware.org References: <20121122163146.GH9650@adacore.com> <201211271545.53340.vapier@gentoo.org> <20121127212445.GD3540@adacore.com> In-Reply-To: <20121127212445.GD3540@adacore.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1427032.TfDR5AJALY"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201211271639.21596.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00083.txt.bz2 --nextPart1427032.TfDR5AJALY Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1571 On Tuesday 27 November 2012 16:24:46 Joel Brobecker wrote: > > Subject: [PATCH] libiberty/md5: fix strict alias warnings > >=20 > > Current libiberty md5 code triggers these warnings with gcc-4.7.1 for m= e: > >=20 > > libiberty/md5.c: In function 'md5_finish_ctx': > > libiberty/md5.c:117:3: warning: dereferencing type-punned pointer will > > break strict-aliasing rules [-Wstrict-aliasing] > > libiberty/md5.c:118:3: warning: dereferencing type-punned pointer will > > break strict-aliasing rules [-Wstrict-aliasing] > >=20 > > The change below fixes things for me. The optimized output (-O2) is > > the same before/after my change on x86_64-linux. I imagine it'll be > > the same for most targets. It seems simpler than using a union on the > > md5_ctx buffer since these are the only two locations in the code > > where this occurs. >=20 > I am on the fence regarding this change. On the one hand, it seems > hardly critical, since it only fixes some warnings, and does not seem > to cause any improvement in the actual code generated. On the other > hand, this module appears to be completely unused in all of GDB (?). > So the risk would be small. For that reason, and the fact that the code > has been in since end of July, I think it's OK to include it, and > avoid the warnings. yeah, i don't think it's critical. i mentioned it because i was carrying i= t=20 in Gentoo's 7.5 patchset (due to the build warnings). i also can't find any md5 usage in gdb. binutils uses it in the linker, bu= t=20 that seems to be all. i'll commit it to the branch. -mike --nextPart1427032.TfDR5AJALY Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJQtTMJAAoJEEFjO5/oN/WBlP4QAORfPH8Vw4fVyS0PuOXmPmjv 3amuyFQuiNf2gsJoyUT0ffVFffQ0MaiuQRExLFvXWpk5Eu+M7O4hvoZJFLsrSMEt nQ75BA9oXt0x572VtKEvfT2seAQjO2b03sB7BU5GQynvpiAoJEfq40tsqDwebkIQ 91PIC8rdNuGmYa5k7Q6DHlvgwXyWP2fKOHQoQ5wuoxrHtp94lQG6Bo/XHvR5eF8t bzMciG6b/sC362VnnBeViqvBYY3QqLK52R1EsFiEVnY8lKR594J0tXuhbHhr1fKA JFmsXTy00nfRc3jxiaX+FgbKmOZhBsn1AzOONP8Xll6cNHTqzOHgD3RKOg4EGoIP rX01ru9Zsl3joDEkTW/QSTfZVvjZRT74qusUXYQxaPPFXhMPW8TRX4FKIuF4UIdm mK6ohUHDZvPvftwacPGEgVV+IjWCKZ/HsEASni7dNBIeZ9gHC3rCd0P5Xr7/3Z3c 18leqUnk/iSqjNXq80AOevvGuRtbsCW+WdtdRSoZTJtp196iVY1F+a2OhJdxxbAg mlOxRp/iUyHFgw272qpg+YYRU/kVjIr66b62a1BmWGwKMRIcRQZVhQd5o8m7aQdw S9lD2D/6JNTv5mq/zcf0gQG/goqgaqYOt3kocC5n6XkrOKk3YwmJX7XBmsKGGs0p 8IiMsztwJYQmByTVgmcD =oGr5 -----END PGP SIGNATURE----- --nextPart1427032.TfDR5AJALY--