Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb@sourceware.org
Subject: Re: Switch -Wunused-variable on?
Date: Sun, 22 Apr 2012 08:23:00 -0000	[thread overview]
Message-ID: <20120422082240.GA21311@host2.jankratochvil.net> (raw)
In-Reply-To: <m3fwbwxmor.fsf@redhat.com>

On Sun, 22 Apr 2012 09:14:44 +0200, Sergio Durigan Junior wrote:
> However, before continuing to prepare this patch, I would like what you
> think about enabling -Wunused-variable by default in the building.

There are more useful -Wunused* options, GDB uses now:
	-Wno-unused -Wunused-value -Wunused-function

IIRC the counterargument for -Wunused-variable was that GDB contains various
#if-compiled code where is a nightmare to get the code right with matching
#if-clauses also for the variables being used by various #if-compiled code
chunks.  I could not find that mail now in the time I gave to it.

I believe more -Wunused* would be worth it, maybe the mail was before Joel
started to disable -Werror for releases so that claim about problematic
#if-clauses is no longer valid.


Thanks,
Jan


  reply	other threads:[~2012-04-22  8:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-22  8:06 Sergio Durigan Junior
2012-04-22  8:23 ` Jan Kratochvil [this message]
2012-04-22 20:25   ` Sergio Durigan Junior
2012-04-22 22:25     ` Jeffrey Walton
2012-04-23  8:55       ` Jan Kratochvil
2012-04-23 14:30     ` Tom Tromey
2012-04-23 15:49       ` Sergio Durigan Junior
2012-04-23 18:02         ` Pedro Alves
2012-04-23 18:39           ` Michael Eager
2012-04-24 22:11       ` Maciej W. Rozycki
2012-04-25  7:51         ` Andreas Schwab
2012-04-25 15:57           ` Maciej W. Rozycki
2012-04-25 16:50             ` Andreas Schwab
2012-04-25 17:22               ` Maciej W. Rozycki
2012-04-25 18:13                 ` Andreas Schwab
2012-04-25 18:20                   ` Sterling Augustine
2012-04-25 18:52                     ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120422082240.GA21311@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb@sourceware.org \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox