Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: marc.khouzam@ericsson.com, gdb@sourceware.org
Subject: Re: Pending breakpoints on lines that don't exist
Date: Wed, 04 Jan 2012 07:17:00 -0000	[thread overview]
Message-ID: <20120104071658.GR2742@adacore.com> (raw)
In-Reply-To: <E1RiJ46-0003KZ-Nk@fencepost.gnu.org>

> Not to me, FWIW.  At the very least, we should have asked a different
> question than we ask in the "normal" pending-breakpoint use case.

I think we can look at this in the same context as Jan's general
comment: It would be nice if GDB was a little more descriptive of
what is happening, why it is doing what it is doing, propose
explicit recipes for doing other things if this is not what the
user wants, etc. It's a bit like what git often does. For instance
(you do not have to real the whole output, it's just meant to show
helpful git tries to be):

    | % git pull
    | You asked me to pull without telling me which branch you
    | want to merge with, and 'branch.private.merge' in
    | your configuration file does not tell me, either. Please
    | specify which branch you want to use on the command line and
    | try again (e.g. 'git pull <repository> <refspec>').
    | See git-pull(1) for details.
    |
    | If you often merge with the same branch, you may want to
    | use something like the following in your configuration file:
    |
    |     [branch "private"]
    |     remote = <nickname>
    |     merge = <remote-ref>
    |
    |     [remote "<nickname>"]
    |     url = <url>
    |     fetch = <refspec>
    |
    | See git-config(1) for details.

I kind of like the idea.   But in this case, I think it would be
too verbose. Currently, we have:

    (gdb) b foo.c:100
    No line 100 in file "foo.c".
    Make breakpoint pending on future shared library load? (y or [n]) n

I find that the error message is precise and complete. But I do not
want to remove the option of making the breakpoint pending, because
some users might have, in fact, meant what they were doing. And if
the user made an error, do you think they would not understand what
error they made that triggered the question?

-- 
Joel


  reply	other threads:[~2012-01-04  7:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-03 21:30 Marc Khouzam
2012-01-04  3:52 ` Joel Brobecker
2012-01-04  5:07   ` Eli Zaretskii
2012-01-04  7:17     ` Joel Brobecker [this message]
2012-01-04  8:08       ` Eli Zaretskii
2012-01-04  9:13         ` Joel Brobecker
2012-01-06  2:30   ` Marc Khouzam
2012-01-04 20:49 ` Tom Tromey
2012-01-05 12:56   ` Pedro Alves
2012-01-04 14:28 Richard Guenther
2012-01-04 14:29 ` Richard Guenther
2012-01-04 20:42 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120104071658.GR2742@adacore.com \
    --to=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb@sourceware.org \
    --cc=marc.khouzam@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox