From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb@sourceware.org, Andrey Smirnov <andrew.smirnov@gmail.com>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: Two quick questions
Date: Mon, 28 Nov 2011 22:09:00 -0000 [thread overview]
Message-ID: <20111128220917.GA10254@ednor.casa.cgf.cx> (raw)
In-Reply-To: <20111128153809.GB17887@adacore.com>
On Mon, Nov 28, 2011 at 07:38:09AM -0800, Joel Brobecker wrote:
>> 1. Since neither
>> http://www.sourceware.org/gdb/current/onlinedocs/gdbint/Coding-Standards.html
>> nor http://sourceware.org/gdb/wiki/JoelsCodingStyleCheatSheet
>> mentions this, or at least yours myopic truly haven't noticed it,
>> I wonder what is the GDB's allegiance in the Tabs, Spaces, Tabs +
>> Spaces holy war? Who are the infidels we must crush? :) The
>> reason I'm asking is that I don't want to generate false diffs
>> just because I re-indented the line in different style.
>
>We use tabs mostly, optionally followed by spaces if a line of code
>doesn't exactly start at a tabulation. Although it's perfectly fine
>to tabify a line of code that you're modifying, I would personally
>prefer that you don't touch lines just for the sake of tabifying.
>Others might disagree (hence the "personally"), but these little
>changes don't bring anything in terms of readability, mess up the
>indentation when reading diffs, and also potentially create merge
>conflicts for changes that are essentially no-ops.
I think most people would agree that gratuitously reindenting lines that
haven't been touched is really a bad idea.
>> Where is that "gdb GNATS bug reporting database"? I can't help but
>> feel guilty for being a security threat, but I just can't find it.
>> There is a Bugzilla, I've seen it, but those two don't seem to be
>> related.
>
>I don't know much about that one, and who might have created an
>account for you. For GDB, we've transitioned to buzilla, as you
>have found. We used to use gnats, but no more.
Wow, that's ancient. I need to move that message into the 21st century.
Also, I suspect that the script shouldn't be creating bugzilla accounts
at all.
cgf
next prev parent reply other threads:[~2011-11-28 22:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 8:47 Andrey Smirnov
2011-11-28 15:38 ` Joel Brobecker
2011-11-28 22:09 ` Christopher Faylor [this message]
2011-11-29 3:33 ` Andrey Smirnov
2011-11-29 20:56 ` Christopher Faylor
2011-11-29 3:25 ` Andrey Smirnov
2011-11-29 4:10 ` Stan Shebs
2011-11-29 4:34 ` Andrey Smirnov
2011-11-29 4:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128220917.GA10254@ednor.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@sourceware.org \
--cc=andrew.smirnov@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox