Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: gdb@sourceware.org
Subject: Re: Python and target-async
Date: Mon, 05 Sep 2011 15:54:00 -0000	[thread overview]
Message-ID: <201109051653.54051.pedro@codesourcery.com> (raw)
In-Reply-To: <CAPftXU+cKNwhxFwf+2Pk8=ferJKRTXm==j50ukranwMMXFmu5Q@mail.gmail.com>

On Friday 19 August 2011 14:35:07, Kevin Pouget wrote:
> furthermore, the `gdb.execute("detach")' which I commented out above,
> leads to the internal_error that I reported in
> http://sourceware.org/bugzilla/show_bug.cgi?id=13110 :
> 
> > ...gdb/thread.c:623: internal-error: is_thread_state: Assertion `tp' failed.
> > A problem internal to GDB has been detected,
> > further debugging may prove unreliable.
> 
> Any thought on what to do for that?
> 

This.  Tested on x86_64-linux and applied.

But I'm now wondering if we actually ever need the registers_changed
call here or in wait_for_inferior nowadays --- we flush threads'
register caches when we resume them (target_resume).

-- 
Pedro Alves

2011-09-05  Pedro Alves  <pedro@codesourcery.com>

	PR cli/13110

	gdb/
	* infrun.c (fetch_inferior_event): Check if there's a selected
	thread before checking if the selected thread is executing.

---
 gdb/infrun.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Index: src/gdb/infrun.c
===================================================================
--- src.orig/gdb/infrun.c	2011-09-05 15:50:49.000000000 +0100
+++ src/gdb/infrun.c	2011-09-05 15:57:10.693964411 +0100
@@ -2749,7 +2749,9 @@ fetch_inferior_event (void *client_data)
      switches threads anyway).  If we didn't do this, a spurious
      delayed event in all-stop mode would make the user lose the
      selected frame.  */
-  if (non_stop || is_executing (inferior_ptid))
+  if (non_stop
+      || (!ptid_equal (inferior_ptid, null_ptid)
+	  && is_executing (inferior_ptid)))
     registers_changed ();
 
   make_cleanup_restore_integer (&execution_direction);


      parent reply	other threads:[~2011-09-05 15:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31 13:52 Kevin Pouget
2011-05-31 17:44 ` Pedro Alves
2011-05-31 17:54   ` Kevin Pouget
2011-06-02 13:28     ` Pedro Alves
2011-08-17 11:37       ` Kevin Pouget
2011-08-17 12:26         ` Pedro Alves
2011-08-17 13:17           ` Kevin Pouget
2011-08-19 13:35             ` Kevin Pouget
2011-08-30 13:14               ` Pedro Alves
2011-08-30 15:54                 ` Jan Kratochvil
2011-09-02 17:13                   ` Pedro Alves
2011-09-05 15:54               ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109051653.54051.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb@sourceware.org \
    --cc=kevin.pouget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox