From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1207 invoked by alias); 27 Jun 2011 09:46:43 -0000 Received: (qmail 1198 invoked by uid 22791); 27 Jun 2011 09:46:42 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.nokia.com (HELO mgw-da01.nokia.com) (147.243.128.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Jun 2011 09:46:28 +0000 Received: from gar.localnet (berwst16747.europe.nokia.com [172.25.167.47]) by mgw-da01.nokia.com (Switch-3.4.4/Switch-3.4.3) with ESMTP id p5R9kQIh012281 for ; Mon, 27 Jun 2011 12:46:27 +0300 From: =?iso-8859-1?q?Andr=E9_P=F6nitz?= To: gdb@sourceware.org Subject: Re: patches for mac support Date: Mon, 27 Jun 2011 09:46:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.32-21-generic; KDE/4.4.5; i686; ; ) References: <9B2A7195-51A9-4F40-97B9-159E041D3174@nokia.com> <3AEF56B29352C444960F3B876394346082CF30@008-AM1MPN1-033.mgdnok.nokia.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201106271152.59206.andre.poenitz@nokia.com> X-Nokia-AV: Clean X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00145.txt.bz2 On Monday 27 June 2011 10:59:12 ext Tristan Gingold wrote: > [...] > > On Jun 23, 2011, at 10:07 PM, Fawzi Mohamed wrote: > > [...] > >>> I have worked on bug http://sourceware.org/bugzilla/show_bug.cgi?id=11488 . > >>> Now I think that I have reached to bottom of it, and I have a set of clean patches that could use a review. > >>> > >>> Apple gdb simply ignores the eh_frame sections for the libraries without embedded dwarf info, not using eh information (which was the first patch that I submitted) but I find that one should be able to use them, so I looked further and found the "correct" fix. > >>> As the path to it was a bit convoluted I have done a few improvements to pieces of code that did fail as consequence of the original bug. > >>> > >>> The "main" fix is > >>> http://sourceware.org/bugzilla/attachment.cgi?id=5816&action=diff > >>> which fixes the mmaped read of sections. > >> > >> We (AdaCore) has something very similar in our internal tree. I very recently worked on submitting a patch to fix this issue. > >> The submitted patch was larger as I tried to clean-up this API. > > > > great, I don't care the way it goes, as long as it gets fixed..., > > so I suppose I can skip submitting it, unless yours doesn't get accepted. > > A pity hat you didn't tell this in the bug, I would have spared some debugging, > > I am a lazy guy too :-) > > > I am a lazy guy ;)... > > Anyway, I have just committed our patch. Thanks a lot for the effort. > BTW, do you (or Nokia) have the FSF copyright assignment ? There should be a company-wide one for gdb. Extremely agile process btw. But is that relevant at all if you apply _your_ patch? Regards, Andre'