From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-38786-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 12977 invoked by alias); 3 Mar 2011 18:59:43 -0000
Received: (qmail 12968 invoked by uid 22791); 3 Mar 2011 18:59:42 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 18:59:36 +0000
Received: (qmail 24652 invoked from network); 3 Mar 2011 18:59:34 -0000
Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 3 Mar 2011 18:59:34 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb@sourceware.org
Subject: Re: [PATCH] arm reversible : progress <patch_1_phase_2>
Date: Thu, 03 Mar 2011 18:59:00 -0000
User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.0; x86_64; ; )
Cc: Michael Snyder <msnyder@vmware.com>, Tom Tromey <tromey@redhat.com>, paawan oza <paawan1982@yahoo.com>
References: <341905.10459.qm@web112513.mail.gq1.yahoo.com> <m3d3m8xdf7.fsf@fleche.redhat.com> <4D6FDFDB.5010706@vmware.com>
In-Reply-To: <4D6FDFDB.5010706@vmware.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201103031859.44388.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00040.txt.bz2

On Thursday 03 March 2011 18:37:15, Michael Snyder wrote:
> >>> diff -urN arm_new/arm-linux-tdep.c arm_orig/arm-linux-tdep.c
> > 
> > The patch is reversed.
> 
> 
> Oza, you probably meant to say "-upN".

Nah, -r is to recurse in subdirectories, that was correct.
The problem is in the use of 'diff $NEW $OLD'.  It should
be 'diff $OLD $NEW'.

But while at it, please do add the -p as Michael is suggesting.
It makes reading the patches easier.

Are you diffing two copies of the tree (one pristine, one
edited)?  I suggest investing some time on learning to
work with some patch series management tool or process.
E.g., I work on top of a cvs checkout and manage my
patches with quilt; others use git, or stgit.

-- 
Pedro Alves