From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 959 invoked by alias); 2 Mar 2011 09:40:32 -0000 Received: (qmail 949 invoked by uid 22791); 2 Mar 2011 09:40:31 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Mar 2011 09:40:25 +0000 Received: (qmail 9557 invoked from network); 2 Mar 2011 09:40:23 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 2 Mar 2011 09:40:23 -0000 From: Pedro Alves To: gdb@sourceware.org Subject: Re: question, xmalloc and gdbserver? Date: Wed, 02 Mar 2011 09:40:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.6.0; x86_64; ; ) Cc: Michael Snyder References: <4D6D8067.9090802@vmware.com> In-Reply-To: <4D6D8067.9090802@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201103020940.21789.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00011.txt.bz2 On Tuesday 01 March 2011 23:25:27, Michael Snyder wrote: > What's the policy about using malloc vs. xmalloc in gdbserver? > I notice both are used, with xmalloc being favored, but there are > still quite a few calls to malloc. I think malloc is used when a failure is not to be considered fatal, e.g., when the size of the data is determined by the input. Doug went through and fixed a bunch a while ago (yearly 2009). You should be able to find the discussions around the patches in the archives. Basically, if there's no explicit check for NULL after malloc, then it's quite likely a new call that went in after Doug's fixes. -- Pedro Alves