From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Edjunior Barbosa Machado <emachado@br.ibm.com>, gdb@sourceware.org
Subject: Re: 'finish' command on ppc64
Date: Mon, 08 Nov 2010 15:43:00 -0000 [thread overview]
Message-ID: <20101108154249.GC2811@adacore.com> (raw)
In-Reply-To: <20101108122443.GA28189@host0.dyn.jankratochvil.net>
> It was discussed at:
> Re: [FYI] Inlining support, rough patch
> http://sourceware.org/ml/gdb-patches/2009-06/msg00786.html
>
> with some Fedora patch (later dropped) so that after `finish' GDB would
> _always_ stay at the caller line.
Interesting. I'm not sure I would agree if the jump was the last insn
of the line... Showing the caller's line in this case would be a
departure from the usual behavior of showing the next insn, no?
> Currently testcases expect both cases:
> gdb.base/finish.exp
> # Some architectures will have one or more instructions after the
> # call instruction which still is part of the call sequence, so we
> # must be prepared for a "finish" to show us the void_func call
> # again as well as the statement after.
I think that's fine.
--
Joel
prev parent reply other threads:[~2010-11-08 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 12:10 Edjunior Barbosa Machado
2010-11-08 12:25 ` Jan Kratochvil
2010-11-08 15:43 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108154249.GC2811@adacore.com \
--to=brobecker@adacore.com \
--cc=emachado@br.ibm.com \
--cc=gdb@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox