From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15684 invoked by alias); 12 Feb 2010 06:16:15 -0000 Received: (qmail 15674 invoked by uid 22791); 12 Feb 2010 06:16:13 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Feb 2010 06:16:09 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A4A122BAC05; Fri, 12 Feb 2010 01:16:07 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id sAYDN9p645pZ; Fri, 12 Feb 2010 01:16:07 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 09C0C2BAC02; Fri, 12 Feb 2010 01:16:07 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 37280F59AE; Fri, 12 Feb 2010 10:15:58 +0400 (RET) Date: Fri, 12 Feb 2010 06:16:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Pedro Alves , gdb@sourceware.org, Kai Tietz , Chris Sutcliffe Subject: Re: [gdb-7.1] 10 days to branching... Message-ID: <20100212061558.GA6205@adacore.com> References: <20100201081928.GA9204@adacore.com> <20100203193934.GA12020@ednor.casa.cgf.cx> <201002061626.06963.pedro@codesourcery.com> <20100212051007.GI2919@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100212051007.GI2919@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00082.txt.bz2 > | sym_arr[i1] = lookup_symbol_in_language (phys_name, > | NULL, FUNCTIONS_DOMAIN, > | language, > | (int *) NULL); > | - if (sym_arr[i1]) > | + /* See PR10966. Remove check on symbol domain and class when > | + we stop using (bad) linkage names on constructors. */ > | + if (sym_arr[i1] && (SYMBOL_DOMAIN (sym_arr[i1]) == VAR_DOMAIN > | + && SYMBOL_CLASS (sym_arr[i1]) == LOC_BLOCK)) > | i1++; Tested with no regression on my end. Regarding my C++ compiler quality, I looked at gdb.sum, and I have 32 KFAILs and 20 FAILs in gdb.cp. However, upon further testing, it appears that the patches does not have the desired effect (or I applied it at the wrong location?): (gdb) b Foo::Foo the class Foo does not have any method named Foo Hint: try 'Foo::Foo or 'Foo::Foo (Note leading single quote.) Make breakpoint pending on future shared library load? (y or [n]) n -- Joel