From: Daniel Jacobowitz <dan@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: dgutson@codesourcery.com, gdb@sourceware.org, binutils@sourceware.org
Subject: Re: gdb segv in arm disassembler
Date: Tue, 26 Jan 2010 02:37:00 -0000 [thread overview]
Message-ID: <20100126023652.GA14474@caradoc.them.org> (raw)
In-Reply-To: <20100126022255.344B284414@ruffy.mtv.corp.google.com>
On Mon, Jan 25, 2010 at 06:22:55PM -0800, Doug Evans wrote:
> Hi.
>
> I'm getting a segv in the arm disassembler when invoked from gdb,
> I think due to this patch.
> When invoked from gdb, info->symtab can be NULL.
Yes. Sorry - I have a patch for this but I have got stuck travelling
instead of finishing the patch series it's part of.
I think this is the appropriate fix:
---
opcodes/arm-dis.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Index: gdb-mainline/opcodes/arm-dis.c
===================================================================
--- gdb-mainline.orig/opcodes/arm-dis.c 2010-01-07 00:22:43.000000000 -0800
+++ gdb-mainline/opcodes/arm-dis.c 2010-01-11 11:18:44.000000000 -0800
@@ -4355,8 +4355,7 @@ print_insn (bfd_vma pc, struct disassemb
long given;
int status;
int is_thumb = FALSE;
- int is_data = (bfd_asymbol_flavour (*info->symtab)
- == bfd_target_elf_flavour) ? TRUE : FALSE;
+ int is_data = FALSE;
int little_code;
unsigned int size = 4;
void (*printer) (bfd_vma, struct disassemble_info *, long);
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2010-01-26 2:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 2:23 Doug Evans
2010-01-26 2:37 ` Daniel Jacobowitz [this message]
2010-01-28 12:48 ` Nick Clifton
2010-01-28 18:27 ` Daniel Jacobowitz
2010-01-28 19:30 ` Daniel Jacobowitz
2010-01-29 10:21 ` Nick Clifton
2010-02-23 12:14 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126023652.GA14474@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=dgutson@codesourcery.com \
--cc=dje@google.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox