From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Stan Shebs <stan@codesourcery.com>
Cc: Hui Zhu <teawater@gmail.com>, gdb@sourceware.org
Subject: Re: cvs tracepoint.c build error
Date: Sat, 16 Jan 2010 22:07:00 -0000 [thread overview]
Message-ID: <20100116220703.GA24229@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <4B520B32.40504@codesourcery.com>
On Sat, 16 Jan 2010 19:53:38 +0100, Stan Shebs wrote:
> Oops, sorry! In retrospect, size_t was a bad idea, this is our own
> code and we should use unsigned long long (large buffers with
> 32x64). Fix forthcoming.
With -Wp,-D_FORTIFY_SOURCE=1 -O1 (Fedora 12) I get also:
tracepoint.c: In function ‘trace_save_command’:
tracepoint.c:2392: error: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result
tracepoint.c:2476: error: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result
tracepoint.c:2481: error: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result
tracepoint.c: In function ‘tfile_open’:
tracepoint.c:2826: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:2847: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c: In function ‘tfile_get_traceframe_address’:
tracepoint.c:3152: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c: In function ‘tfile_trace_find’:
tracepoint.c:3184: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3188: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c: In function ‘tfile_fetch_registers’:
tracepoint.c:3264: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3269: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3296: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c: In function ‘tfile_xfer_partial’:
tracepoint.c:3333: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3342: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3343: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3346: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c: In function ‘tfile_get_trace_state_variable_value’:
tracepoint.c:3380: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3390: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3395: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3398: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
which IMO should be properly checked.
Thanks,
Jan
next prev parent reply other threads:[~2010-01-16 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-16 14:40 Hui Zhu
2010-01-16 18:53 ` Stan Shebs
2010-01-16 22:07 ` Jan Kratochvil [this message]
2010-01-19 3:19 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100116220703.GA24229@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb@sourceware.org \
--cc=stan@codesourcery.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox