Regression: field type preservation: 7.0 -> 7.0.1+HEAD

[Jan Kratochvil <jan.kratochvil@redhat.com>]

Hi,

there is now:
-PASS: gdb.mi/mi-var-child.exp: get children of struct_declarations.s2.u2.u1s1
+FAIL: gdb.mi/mi-var-child.exp: get children of struct_declarations.s2.u2.u1s1
-PASS: gdb.mi/mi2-var-child.exp: get children of struct_declarations.s2.u2.u1s1
+FAIL: gdb.mi/mi2-var-child.exp: get children of struct_declarations.s2.u2.u1s1
-PASS: gdb.python/py-mi.exp: examine container children=0, no pretty-printing
+FAIL: gdb.python/py-mi.exp: examine container children=0, no pretty-printing

due to:
Re: RFA: unbreak typedefed bitfield
http://sourceware.org/ml/gdb-patches/2009-12/msg00295.html
commit fc85da4ee2a7c32afc53b1b334a4f84e2e9bd84e
http://sourceware.org/ml/gdb-cvs/2009-12/msg00100.html
Author: Vladimir Prus <vladimir@codesourcery.com>
Date:   Mon Dec 21 09:50:26 2009 +0000
	PR gdb/10884
	* value.c (value_primitive_field): Call check_typedef
	on the type.

which has landed on gdb_7_0-branch for 7.0.1:
http://sourceware.org/ml/gdb-patches/2009-12/msg00301.html
Author: Joel Brobecker <brobecker@gnat.com>
commit 259702e4c806baf8ba483484ceec8feb94a39a64
http://sourceware.org/ml/gdb-cvs/2009-12/msg00104.html
commit f3f5ad7561d2206b09ef30df979ef58dd014543b
http://sourceware.org/ml/gdb-cvs/2009-12/msg00103.html

PASS: ^done,numchild="4",children=[child={name="struct_declarations.s2.u2.u1s1.d",exp="d",numchild="0",type="int",thread-id="1"},child={name="struct_declarations.s2.u2.u1s1.e",exp="e",numchild="10",type="char [10]",thread-id="1"},child={name="struct_declarations.s2.u2.u1s1.func",exp="func",numchild="0",type="int *(*)(void)",thread-id="1"},child={name="struct_declarations.s2.u2.u1s1.foo",exp="foo",numchild="0",type="efoo",thread-id="1"}],has_more="0"
FAIL: ^done,numchild="4",children=[child={name="struct_declarations.s2.u2.u1s1.d",exp="d",numchild="0",type="int",thread-id="1"},child={name="struct_declarations.s2.u2.u1s1.e",exp="e",numchild="10",type="char [10]",thread-id="1"},child={name="struct_declarations.s2.u2.u1s1.func",exp="func",numchild="0",type="int *(*)(void)",thread-id="1"},child={name="struct_declarations.s2.u2.u1s1.foo",exp="foo",numchild="0",type="enum foo",thread-id="1"}],has_more="0"
wdiff:^done,numchild="4",children=[child={name="struct_declarations.s2.u2.u1s1.d",exp="d",numchild="0",type="int",thread-id="1"},child={name="struct_declarations.s2.u2.u1s1.e",exp="e",numchild="10",type="char [10]",thread-id="1"},child={name="struct_declarations.s2.u2.u1s1.func",exp="func",numchild="0",type="int *(*)(void)",thread-id="1"},child={name="struct_declarations.s2.u2.u1s1.foo",exp="foo",numchild="0",type=[-"efoo"-]{+"enum foo"+},thread-id="1"}],has_more="0"

typedef enum foo efoo;
      struct {
        int d;
        char e[10];
        int *(*func) (void);
        efoo foo;
      } u1s1;
# Test: c_variable-4.61
# Desc: children of struct_declarations.s2.u2.u1s1
mi_list_varobj_children struct_declarations.s2.u2.u1s1 {
    {struct_declarations.s2.u2.u1s1.d d 0 int}
    {struct_declarations.s2.u2.u1s1.e e 10 {char \[10\]}}
    {struct_declarations.s2.u2.u1s1.func func 0 {int \*\(\*\)\((void)?\)}}
    {struct_declarations.s2.u2.u1s1.foo foo 0 efoo}
} "get children of struct_declarations.s2.u2.u1s1"

I find that the type of the field should be really reported before
check_typedef and therefore the patch should be reverted.



Regards,
Jan