From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20772 invoked by alias); 8 Dec 2009 13:57:37 -0000 Received: (qmail 20763 invoked by uid 22791); 8 Dec 2009 13:57:36 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Dec 2009 13:57:30 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB8DulR3023065 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 8 Dec 2009 08:56:47 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nB8Dujam001573 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 8 Dec 2009 08:56:47 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id nB8Dujhh026522; Tue, 8 Dec 2009 14:56:45 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id nB8DuhKJ026521; Tue, 8 Dec 2009 14:56:43 +0100 Date: Tue, 08 Dec 2009 13:57:00 -0000 From: Jan Kratochvil To: Michael Snyder Cc: "tromey@redhat.com" , Joel Brobecker , "gdb@sourceware.org" Subject: Re: Red Hat PIE patch Message-ID: <20091208135643.GA26066@host0.dyn.jankratochvil.net> References: <4B1A9FA4.7000001@vmware.com> <20091205193211.GK2903@adacore.com> <4B1D7C69.70409@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B1D7C69.70409@vmware.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00046.txt.bz2 On Mon, 07 Dec 2009 23:06:33 +0100, Michael Snyder wrote: > Tom Tromey wrote: > > I have not yet reviewed numbers 9, 12, and 14. These touched on things > > that I am less familiar with. I hope to get to them, but if someone > > else wants to take a look, that is fine with me. http://sourceware.org/ml/gdb-patches/2009-11/msg00169.html Patch 2 should be probably dropped as the patch itself makes no sense. There there is IMO some non-stop race unrelated to the PIE patched but triggered by the patchset (causing testsuite regression). http://sourceware.org/ml/gdb-patches/2009-11/msg00170.html Patch 3 has wrong gdbarch dealing but it should affect only Cell frame-specific arches, if at all so did not get to it back. Shouldn't be rather `gdbarch' moved from `struct bp_location' to `struct address_space'? But got lost in the details of gdbarch by Markus Deuling / Ulrich Weigand. > Just FYI, I've applied the patches and done basic "aliveness" > testing. They do seem to work for me, and I will be doing more > with them so I may have further testing words later. Thanks, BTW there are now some add-ons to that series which are still not properly split/integrated/reposted. http://cvs.fedora.redhat.com/viewvc/rpms/gdb/F-12/gdb-archer-pie-addons.patch?content-type=text%2Fplain&view=co Regards, Jan