From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32672 invoked by alias); 2 Oct 2009 18:15:00 -0000 Received: (qmail 32654 invoked by uid 22791); 2 Oct 2009 18:15:00 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Oct 2009 18:14:54 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5EEA32BAB65; Fri, 2 Oct 2009 14:14:52 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vzNLbc-WIKTg; Fri, 2 Oct 2009 14:14:52 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 274CA2BAB55; Fri, 2 Oct 2009 14:14:52 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D65A2F5906; Fri, 2 Oct 2009 11:14:47 -0700 (PDT) Date: Fri, 02 Oct 2009 18:15:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: tromey@redhat.com, ralf.corsepius@rtems.org, gdb@sourceware.org, jan.kratochvil@redhat.com Subject: Re: GDB 6.8.92 available for testing Message-ID: <20091002181447.GS6532@adacore.com> References: <20090930204828.GB31446@adacore.com> <4AC41F44.1040502@rtems.org> <20091001170744.GC6532@adacore.com> <4AC4E4F6.5080500@rtems.org> <4AC630C8.5090508@rtems.org> <200910021804.n92I47I7008266@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200910021804.n92I47I7008266@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00051.txt.bz2 > However, the idiom: > > int len = TYPE_LENGTH(...); > > memcpy(..., ..., len); > > is used in several other places in the GDB tree. I really think that > we should fix all these cases; not just this one. Perhaps the type of length in struct type should be changed to size_t? -- Joel