From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7768 invoked by alias); 1 Oct 2009 17:56:40 -0000 Received: (qmail 7756 invoked by uid 22791); 1 Oct 2009 17:56:39 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Oct 2009 17:56:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9B5E12BABBB; Thu, 1 Oct 2009 13:56:33 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id h4TDTL10qkkB; Thu, 1 Oct 2009 13:56:33 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F17B22BABB9; Thu, 1 Oct 2009 13:56:32 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 55B3AF593F; Thu, 1 Oct 2009 10:29:28 -0700 (PDT) Date: Thu, 01 Oct 2009 17:56:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb@sourceware.org Subject: Re: GDB 6.8.92 available for testing Message-ID: <20091001172928.GE6532@adacore.com> References: <20090930204828.GB31446@adacore.com> <004701ca428e$fa377c50$eea674f0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <004701ca428e$fa377c50$eea674f0$@u-strasbg.fr> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00021.txt.bz2 > 3) gdb.base/shr1.c (wrong format arg type) > 3) is about an address, but "%p" does not seem to be supported by all > C lib format implementation, so I don't know if this can be fixed correctly. We already use %p in a couple of testcase, so let's use it again here. Best to avoid printing stuff on stdout/stderr when writing a testcase, as we don't always have access to the inferior output (for instance, when doing remote debugging), so matching the inferior output in the testcase won't work in those case. But we'd have to dig deeper in the history of this testcase to determine whether removing the printf would not impact the effectiveness of the testcase. For now, I vote for a group hug and the use of %p. > 4) gdb.base/unload.c (format arg not literal) > 5) gdb.base/watchpoint-solib.c (format arg not literal) > 4) and 5) seem more difficult ... Is that the source of the problem? fprintf (stderr, dlerror ()); The following should take care of it: fprintf (stderr, "%s", dlerror ()) -- Joel