Re: GDB 7.0 regressions: s390(x)-linux, ppc(64)-linux, spu-elf

["Ulrich Weigand" <uweigand@de.ibm.com>]

Joel Brobecker wrote:

> The target date for release is Wed, so we're about 48 hours away.
> If you feel confident about your fix, then you should go ahead and
> commit to the branch.  According to the guidelines I remember reading
> somewhere (it might be in the MAINTAINERS file), if the change only
> affects one target, we can also discuss putting that change in. For
> the rest of your patches, we need to look at them individually and
> evaluate the risk. Based on that, we can decide whether delaying
> the release is necessary, and whether each patch should be applied
> to the branch and if yes, whether it should be applied now (for 7.0),
> or only after it has had a chance to be tested a little more on the
> HEAD.


Well, my feeling would be:

- Put in the patches that are testsuite-only (7, 8, 9 in my list)
  They should be harmless and significantly clean up test suite
  results on some platforms

- Put in the solely platform-specific patches (3, 5, 6)
  I've tested these, and they definitely help on those platforms

- The bitfield regression (1) seems a serious error affecting
  multiple platforms that really should be fixed, and the patch
  seems straightforward ...

(All the above patches are already in mainline.)


The remaining two PowerPC-related patches (not yet in mainline)
are more difficult:

- The displaced stepping regression is unfortunate, as it completely
  breaks a new feature.  The patch *should* affect only PowerPC, but
  it does need to touch generic files (infrun.c), so there's always
  some risk.  In any case, I'd prefer to get at least some feedback
  before putting it in ...

- The Obj-C changes are not really a regression, so it may not really
  be critical to put those in.  On the other hand, they just touch
  Obj-C code (except for one PowerPC-specific bugfix), and they 
  drastically improve the situation on PowerPC-64, so it would be
  nice ...  Again, I'd definitely like some feedback first.


Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com