Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Tom Tromey <tromey@redhat.com>
Cc: Nathan Froyd <froydnj@codesourcery.com>,
	Doug Evans <dje@google.com>,
		Pedro Alves <pedro@codesourcery.com>,
	gdb@sourceware.org
Subject: Re: store.exp failure on i686-linux with newer gcc's
Date: Fri, 04 Sep 2009 21:28:00 -0000	[thread overview]
Message-ID: <20090904212804.GA28036@caradoc.them.org> (raw)
In-Reply-To: <m3vdjy8kvx.fsf@fleche.redhat.com>

On Fri, Sep 04, 2009 at 03:23:14PM -0600, Tom Tromey wrote:
> >>>>> "Nathan" == Nathan Froyd <froydnj@codesourcery.com> writes:
> 
> I've been thinking about this patch more and I have one more question.
> 
> Nathan> +	  struct gdbarch *arch = get_frame_arch (frame);
> 
> Nathan> +      struct frame_id frame_id = get_frame_id (frame);
> Nathan> +
> Nathan> +      c = allocate_piece_closure (ctx->num_pieces, ctx->pieces);
> Nathan> +      retval = allocate_computed_value (SYMBOL_TYPE (var),
> Nathan> +					&pieced_value_funcs,
> Nathan> +					c);
> Nathan> +      VALUE_FRAME_ID (retval) = frame_id;
> 
> 
> My understanding is that we can evaluate dwarf expressions that do not
> need a frame.  Will this code do the right thing in that situation?

I *think* so - the frame ID would only be consulted if there were
registers.  I assume we can't get here when the inferior is not
running, since we're passed a frame.  Or is that overly optimistic?

> I am not sure how to construct a situation like that.  Maybe someone
> else knows.

I don't know how to make GCC do it, but SRA or struct-reorg on a
global variable could do that.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2009-09-04 21:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-03 21:50 Doug Evans
2009-09-03 21:58 ` Joel Brobecker
2009-09-03 22:04 ` Pedro Alves
2009-09-03 22:17   ` Doug Evans
2009-09-03 23:44     ` Nathan Froyd
2009-09-04 16:05       ` Tom Tromey
2009-09-04 17:49         ` Nathan Froyd
2009-09-04 18:38           ` Tom Tromey
2009-09-04 20:17             ` Nathan Froyd
2009-09-04 20:18               ` Doug Evans
2009-09-04 21:23       ` Tom Tromey
2009-09-04 21:28         ` Daniel Jacobowitz [this message]
2009-09-04 22:28           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090904212804.GA28036@caradoc.them.org \
    --to=drow@false.org \
    --cc=dje@google.com \
    --cc=froydnj@codesourcery.com \
    --cc=gdb@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox