Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb@sourceware.org
Subject: Re: More info on PR/9711 (quadratic slowdown for deep stack traces)
Date: Thu, 03 Sep 2009 18:40:00 -0000	[thread overview]
Message-ID: <20090903184035.GB4379@adacore.com> (raw)
In-Reply-To: <20090902162402.GQ4379@adacore.com>

> I suppose we could immediately flush the extra frames when the setting
> changes to "off", but on the other hand, I think that the right thing
> to do in frame_find_by_id is to call get_prev_frame_1 anyway. I will
> test that next.

Just for the record, this turned out to be a bad idea.  In the case
when the previous frames had not been computed, we might end up
trying to unwind past main.  This causes a few regressions in one
of gdb.mi testcases. I didn't investigate precisely what was happening
since the suggestion became pretty much irrelevant when I implemented
the cache. See:
   http://www.sourceware.org/ml/gdb-patches/2009-09/msg00085.html

-- 
Joel


      reply	other threads:[~2009-09-03 18:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-01 20:48 Joel Brobecker
2009-09-02  3:42 ` Paul Pluzhnikov
2009-09-02  4:52   ` Joel Brobecker
2009-09-02  4:57     ` Paul Pluzhnikov
2009-09-02 11:43 ` Daniel Jacobowitz
2009-09-02 16:24   ` Joel Brobecker
2009-09-03 18:40     ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090903184035.GB4379@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox