From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb@sources.redhat.com
Subject: Re: Private data members
Date: Wed, 29 Jul 2009 13:39:00 -0000 [thread overview]
Message-ID: <20090729133846.GA29761@caradoc.them.org> (raw)
In-Reply-To: <200907291245.32359.vladimir@codesourcery.com>
On Wed, Jul 29, 2009 at 12:45:32PM +0400, Vladimir Prus wrote:
> At the moment, there are at least 3 places that directly assign
> a value to that field, and while I can convert them easily, nothing
> will prevent a direct assignment to appear in future. In C++,
> one would use 'private' visibility for that member, but it's not
> available in C. So, how about introducing a small convention --
> that members with names ending in '_' are 'private' and should
> never be accessed by outside code. Another alternative is to
> modify the comment on ignore_count, but that is much more likely
> to be ignored.
How about struct { int ignore_count; } private; ? I don't think
ignore_count_ is clear.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-07-29 13:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 8:45 Vladimir Prus
2009-07-29 13:39 ` Daniel Jacobowitz [this message]
2009-07-29 13:41 ` Vladimir Prus
2009-07-29 16:18 ` Samuel Bronson
2009-07-29 16:50 ` Vladimir Prus
2009-07-29 15:32 ` Tom Tromey
2009-07-29 17:30 ` Michael Snyder
2009-07-29 21:56 ` Andreas Schwab
2009-07-29 22:39 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090729133846.GA29761@caradoc.them.org \
--to=drow@false.org \
--cc=gdb@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox