From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1967 invoked by alias); 17 May 2009 11:51:37 -0000 Received: (qmail 1955 invoked by uid 22791); 17 May 2009 11:51:37 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 17 May 2009 11:51:32 +0000 Received: (qmail 29672 invoked from network); 17 May 2009 11:51:30 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 17 May 2009 11:51:30 -0000 From: Pedro Alves To: gdb@sourceware.org Subject: Re: record mode supposed to work on x86_64-linux? Date: Sun, 17 May 2009 11:51:00 -0000 User-Agent: KMail/1.9.10 Cc: Hui Zhu , Andi Kleen References: <20090515184058.GA7326@basil.nowhere.org> <200905161735.35466.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200905171252.01243.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00102.txt.bz2 On Sunday 17 May 2009 01:15:00, Hui Zhu wrote: > Hi Pedro, >=20 > What do you think about this one? I think it's good, thanks. > 2009-05-17 Hui Zhu >=20=20=20=20=20=20=20=20=20 > * i386-tdep.c (i386_process_record): Remove the static of it. > (i386_gdbarch_init): Remove the set_gdbarch_process_record. > * i386-tdep.c (i386_process_record): New extern. > * i386-linux-tdep.c (i386_linux_init_abi): Call > set_gdbarch_process_record. Please consider the alternative ChangeLog suggestions below instead. > * i386-tdep.c (i386_process_record): Remove the static of it. * i386-tdep.c (i386_process_record): Make it extern. > (i386_gdbarch_init): Remove the set_gdbarch_process_record. =46rom this entry, it isn't clear what you're removing. Actually, it sounds like you're removing the function implementation. Consider instead: (i386_gdbarch_init): Remove the set_gdbarch_process_record call. ^^^^ or even: (i386_gdbarch_init): Don't call set_gdbarch_process_record here. > * i386-tdep.c (i386_process_record): New extern. ^ typo * i386-tdep.h (i386_process_record): Declare. (`new extern' sounds like adding a new variable or function, but you're just changing the linkage of an existing function.) --=20 Pedro Alves