From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11646 invoked by alias); 20 Apr 2009 20:32:12 -0000 Received: (qmail 11637 invoked by uid 22791); 20 Apr 2009 20:32:11 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Apr 2009 20:32:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 70A062BAB9B; Mon, 20 Apr 2009 16:32:04 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id EqlfKIGv51k3; Mon, 20 Apr 2009 16:32:04 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 38B552BAB94; Mon, 20 Apr 2009 16:32:04 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5587AF58C9; Mon, 20 Apr 2009 13:31:52 -0700 (PDT) Date: Mon, 20 Apr 2009 21:15:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb@sourceware.org Subject: Re: [Ada/dwarf] New DW_AT_GNAT_descriptive_type DWARF attribute... Message-ID: <20090420203152.GR2904@adacore.com> References: <20090417161934.GW7585@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00157.txt.bz2 > I think you should trust your judgment here; you're the expert in this > area. Wow, thanks! :) > Joel> The changes in GDB are relatively small, I think - at least in > Joel> the DWARF reader part. We added a field in the gnat_specific part > Joel> of struct type, and I can see how it could trigger some protests. > Joel> But we can discuss the specifics of the patch if there are no > Joel> objections to this new attribute. > > I don't see a gnat_specific part of struct type at all. Is this from > an unsubmitted change? Yes. This is actually part of the meat of that change were we add the gnat_specific to the union to stuff some ada-specific data, much like we do for C++ with the cplus_specific area. I'll try to prepare a patch for everyone to see. -- Joel