Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: dje@google.com (Doug Evans)
To: gdb@sourceware.org
Subject: when can find_thread_pid (inferior_ptid) return NULL?
Date: Thu, 26 Mar 2009 21:36:00 -0000	[thread overview]
Message-ID: <20090326213642.B9E771C74E3@localhost> (raw)

Hi.  Some places in gdb assert that find_thread_pid (inferior_ptid)
is never NULL.

e.g.

struct thread_info*
inferior_thread (void)
{
  struct thread_info *tp = find_thread_pid (inferior_ptid);
  gdb_assert (tp);
  return tp;
}

Other places check.  E.g.

make_cleanup_restore_current_thread:

      tp = find_thread_pid (inferior_ptid);
      if (tp)
	tp->refcount++;

Since delete_thread_1 has this:

  /* If this is the current thread, or there's code out there that
     relies on it existing (refcount > 0) we can't delete yet.  Mark
     it as exited, and notify it.  */
  if (tp->refcount > 0
      || ptid_equal (tp->ptid, inferior_ptid))
    {

I would expect that one can always assert
find_thread_pid (inferior_ptid) != NULL.

Is that true?
Or are there situations where it's not true?


             reply	other threads:[~2009-03-26 21:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-26 21:36 Doug Evans [this message]
2009-03-26 22:35 ` Pedro Alves
2009-03-27  0:54   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090326213642.B9E771C74E3@localhost \
    --to=dje@google.com \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox