From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16560 invoked by alias); 14 Oct 2008 15:49:42 -0000 Received: (qmail 16549 invoked by uid 22791); 14 Oct 2008 15:49:41 -0000 X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 14 Oct 2008 15:48:48 +0000 Received: from tschwinge by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Kpm66-0000bE-T0; Tue, 14 Oct 2008 11:46:10 -0400 Date: Tue, 14 Oct 2008 15:49:00 -0000 From: Thomas Schwinge To: Pedro Alves Cc: Ulrich Weigand , gdb@sourceware.org, "Alfred M. Szmidt" , bug-hurd@gnu.org Subject: Re: [PATCH?] GDB HEAD (partly) broken for GNU/Hurd Message-ID: <20081014154610.GJ21737@fencepost.gnu.org> References: <200810131640.m9DGePBo027792@d12av02.megacenter.de.ibm.com> <200810131935.35253.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="q5r20fdKX+PFtYHw" Content-Disposition: inline In-Reply-To: <200810131935.35253.pedro@codesourcery.com> X-Homepage: http://www.thomas.schwinge.homeip.net/ User-Agent: Mutt/1.5.11 X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00061.txt.bz2 --q5r20fdKX+PFtYHw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2176 Hello! On Mon, Oct 13, 2008 at 07:35:34PM +0100, Pedro Alves wrote: > Thanks Thomas :-) One thing I asked myself was, if gnu-nat.c couldn't be= using > the port's id as thread ids instead of a locally auto-generated number. = Maybe > the thread id of the main thread would be preserved across execs this way= , but, > this is off-scope for now. I can't tell without having a detailed look at that -- for which I absolutely don't have the time at the moment, unfortunately. I made this a TODO item: > On Monday 13 October 2008 17:40:25, Ulrich Weigand wrote: > > Hmm. It would appear that "set exec-wrapper" is currently broken with > > the gnu-nat.c target, right? >=20 > Yeah, it appears so. Don't know if it's possible to get rid of the local > pending execs handling in gnu-nat.c. An alternative would be to make > pending_execs a property of inferior.h:`struct inferior' instead of of > gnu-nat.c:`struct inf'. Another TODO item: > (I also notice that when going through the shell in non-stop > mode, it would be more correct to resume all threads --- we > don't want non-stop and its scheduler-locking to apply to the shell. > Basically, non-stop should be off if there are pending execs. > This was an existing issue, and doesn't affect linux today, so I'll > just ignore that for now, as it needs more tweaking to fix.) And non-stop mode isn't even supported with gnu-nat.c -- yet another TODO item: > What do you guys think? Thomas, could you try the attached patch > on the Hurd, please? I just gave it a spin on x86-64-unknown-linux-gnu > without regressions. > 2008-10-13 Pedro Alves >=20 > * fork-child.c (startup_inferior): Only set threads not-executing > after getting all the pending execs. On TARGET_WAITKIND_IGNORE, > keep waiting, don't resume. On all other cases but > TARGET_WAITKIND_SIGNALLED and TARGET_WAITKIND_EXITED, switch to > the event ptid. Fine on Hurd as well, thanks! Regards, Thomas --q5r20fdKX+PFtYHw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline Content-length: 191 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (GNU/Linux) iD8DBQFI9L7Cgfzh735dTTURAgS1AJ9AKlN47ZrkU1UNYLRHLQhQeQD4qACgmm3M h9TrVWuc/10fdUAOQHv1W2E= =aASR -----END PGP SIGNATURE----- --q5r20fdKX+PFtYHw--