From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb@sources.redhat.com
Subject: Re: MI threads behaviour
Date: Wed, 16 Jul 2008 13:33:00 -0000 [thread overview]
Message-ID: <20080716133316.GA3080@caradoc.them.org> (raw)
In-Reply-To: <200807161723.18272.vladimir@codesourcery.com>
On Wed, Jul 16, 2008 at 05:23:17PM +0400, Vladimir Prus wrote:
> > If the CLI command changes that
> > thread, then the GUI needs to update its state from the notification.
> > If it doesn't change the thread, the GUI doesn't need to update.
> >
> > So what purpose is =thread-changed,thread-id="1" in the above example?
>
> The general purpose of "thread-selected" notification is to inform the
> frontend that the user wants a given thread to be selected in UI.
> Skipping such notification for
>
> -interpreter-exec --thread 1 console "thread 1"
>
> is OK only if we document that the "--thread" parameter should always be
> the selected UI thread, which seems a hard assumption. Say, a frontend
> might want to allow user-defined commands to be run on stop and send CLI
> commands on stop explicitly (either because breakpoint commands are not
> implemented in MI, or because frontend wants to run some commands no
> matter which breakpoint is hit). In non-stop mode, such commands presumably,
> will be run in the context of the thread that hit a breakpoint. But this
> thread is not necessary the thread that is selected in UI. I don't have
> a fully-baked example that will be broken by skipping the notification in
> this case; but I'm not confident such example will not arise.
I think you're assigning conflicting meanings to the same thing here.
If "thread 1" means "select thread 1 in the UI", then doesn't the
context of the command have to be whatever was previously selected in
the UI? I don't think there's a need for breakpoint commands to be
able to change the UI selection, and it would be very confusing since
they could happen while the user was looking at something.
Anyway, objection withdrawn; do whatever seems best to you. I can't
follow this any more :-)
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2008-07-16 13:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 12:02 Vladimir Prus
2008-07-08 5:29 ` Vladimir Prus
2008-07-09 21:03 ` Daniel Jacobowitz
2008-07-10 13:14 ` Marc Khouzam
2008-07-14 15:56 ` Pawel Piech
2008-07-14 16:04 ` Marc Khouzam
2008-07-14 20:27 ` Pawel Piech
2008-07-16 11:51 ` Vladimir Prus
2008-07-16 12:11 ` Daniel Jacobowitz
2008-07-16 12:52 ` Vladimir Prus
2008-07-16 13:08 ` Daniel Jacobowitz
2008-07-16 13:23 ` Vladimir Prus
2008-07-16 13:33 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080716133316.GA3080@caradoc.them.org \
--to=drow@false.org \
--cc=gdb@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox