From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30779 invoked by alias); 29 Jun 2008 14:48:31 -0000 Received: (qmail 30765 invoked by uid 22791); 29 Jun 2008 14:48:30 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 29 Jun 2008 14:48:00 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 3D78E98413; Sun, 29 Jun 2008 14:47:59 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 27A719809E; Sun, 29 Jun 2008 14:47:59 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KCyC6-000399-DP; Sun, 29 Jun 2008 10:47:58 -0400 Date: Sun, 29 Jun 2008 14:48:00 -0000 From: Daniel Jacobowitz To: Stan Shebs Cc: gdb@sourceware.org Subject: Re: Encouraging patch reviewers Message-ID: <20080629144758.GC11412@caradoc.them.org> Mail-Followup-To: Stan Shebs , gdb@sourceware.org References: <48668628.8050904@earthlink.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48668628.8050904@earthlink.net> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00309.txt.bz2 On Sat, Jun 28, 2008 at 11:42:48AM -0700, Stan Shebs wrote: > At the GCC summit we discussed patch review a bit, and one of the > thoughts was that people who are not official maintainers of anything > will often study a posted patch, and get a good idea of whether it's > desirable, needs fixes, etc, but then maybe don't say anything because it > won't be an "official" opinion. But it really does help to post such > reviews, and quite likely a maintainer will simply rubberstamp it, saving > time all around. So speaking up really helps, but in looking at > gdb/MAINTAINERS I don't see anything that explicitly encourages people to > post their own reviews - it just says "anyone [...] may suggest changes or > ask questions". Does anybody think we need stronger phrasing here, and if > so, how should it read? I'd be happy with something stronger. -- Daniel Jacobowitz CodeSourcery