From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-31071-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 14766 invoked by alias); 17 Feb 2008 15:26:49 -0000
Received: (qmail 14757 invoked by uid 22791); 17 Feb 2008 15:26:48 -0000
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 17 Feb 2008 15:26:29 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id 65BD598216; 	Sun, 17 Feb 2008 15:26:27 +0000 (GMT)
Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) 	by nan.false.org (Postfix) with ESMTP id 3099F980E0; 	Sun, 17 Feb 2008 15:26:27 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.69) 	(envelope-from <drow@caradoc.them.org>) 	id 1JQlPN-0001KK-US; Sun, 17 Feb 2008 10:26:26 -0500
Date: Sun, 17 Feb 2008 15:26:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Bin Chen <binary.chen@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb@sourceware.org
Subject: Re: (len % 1) != 0
Message-ID: <20080217152625.GA4810@caradoc.them.org>
Mail-Followup-To: Bin Chen <binary.chen@gmail.com>, 	Eli Zaretskii <eliz@gnu.org>, gdb@sourceware.org
References: <5800c1cc0802162157g3ac31acas4ae95585b9b2e263@mail.gmail.com> <E1JQkG0-0005DD-0k@fencepost.gnu.org> <5800c1cc0802170641g68ab2e5fte724cd076412333@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5800c1cc0802170641g68ab2e5fte724cd076412333@mail.gmail.com>
User-Agent: Mutt/1.5.17 (2007-12-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2008-02/txt/msg00117.txt.bz2

On Sun, Feb 17, 2008 at 10:41:36PM +0800, Bin Chen wrote:
> Hi Daniel,
> 
> Is it a bug?

Yes.  Fixed as below.

-- 
Daniel Jacobowitz
CodeSourcery

2008-02-17  Daniel Jacobowitz  <dan@codesourcery.com>

	* server.c (handle_query): Correct length check.

Index: server.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
retrieving revision 1.64
diff -u -p -r1.64 server.c
--- server.c	14 Feb 2008 16:42:55 -0000	1.64
+++ server.c	17 Feb 2008 15:25:22 -0000
@@ -649,7 +649,7 @@ handle_query (char *own_buf, int packet_
       char *mon = malloc (PBUFSIZ);
       int len = strlen (own_buf + 6);
 
-      if ((len % 1) != 0 || unhexify (mon, own_buf + 6, len / 2) != len / 2)
+      if ((len % 2) != 0 || unhexify (mon, own_buf + 6, len / 2) != len / 2)
 	{
 	  write_enn (own_buf);
 	  free (mon);