Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Robin Getz <rgetz@blackfin.uclinux.org>
To: "Daniel Jacobowitz" <drow@false.org>
Cc: gdb@sourceware.org
Subject: Re: Testsuite question...
Date: Wed, 05 Dec 2007 16:54:00 -0000	[thread overview]
Message-ID: <200712051155.00860.rgetz@blackfin.uclinux.org> (raw)
In-Reply-To: <20071205160728.GA24621@caradoc.them.org>

On Wed 5 Dec 2007 11:07, Daniel Jacobowitz pondered:
> On Wed, Dec 05, 2007 at 10:59:37AM -0500, Robin Getz wrote:
> > proc test_breakpoints { } {
> >     gdb_test "stop in main" "Breakpoint.*at.*: file.*average\.c, line 38\."
> >     gdb_test "status" "Num.*Type.*Disp.*Enb.*Address.*What\r\n1\[\r\]+breakpoint\[ \r\]+keep y.*in main at.*average\.c:38.*"
> >     gdb_test "stop at 43" "Breakpoint.*at.*: file.*average\.c, line 43.*"
> 
> > When you do a "stop symbol", where the symbol is in the application,
> > it  works fine,
> > 
> > (gdb) stop in main
> > Breakpoint 1 at 0x4401b2: file
> /home/rgetz/blackfin/toolchain/binutils-2.17/gdb/testsuite/gdb.base/average.c, line 38.
> 
> So - should this change the notion of the current source file or not?

I would not think so.

> Break does not, so stop in shouldn't either.  Therefore the behaviour
> you're seeing seems reasonable.  I recommend fixing the test,
> something like stop at average.c:43.

OK - will do - Something like:

Index: gdb.base/dbx.exp
===================================================================
--- gdb.base/dbx.exp    (revision 2024)
+++ gdb.base/dbx.exp    (working copy)
@@ -266,8 +266,8 @@
 proc test_breakpoints { } {
     gdb_test "stop in main" "Breakpoint.*at.*: file.*average\.c, line 38\."
     gdb_test "status" "Num.*Type.*Disp.*Enb.*Address.*What\r\n1\[ \r\]+breakpoint\[ \r\]+keep y.*in main at.*average\.c:38.*"
-    gdb_test "stop at 43" "Breakpoint.*at.*: file.*average\.c, line 43.*"
-    gdb_test "stop in 43" "Usage: stop in <function . address>"
+    gdb_test "stop at average.c:43" "Breakpoint.*at.*: file.*average\.c, line 43.*"
+    gdb_test "stop in average.c:43" "Usage: stop in <function . address>"
     gdb_test "stop at main" "Usage: stop at <line>"
 }

Thanks
-Robin


  reply	other threads:[~2007-12-05 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-05 15:59 Robin Getz
2007-12-05 16:07 ` Daniel Jacobowitz
2007-12-05 16:54   ` Robin Getz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-06-22 16:53 testsuite question Manoj Iyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712051155.00860.rgetz@blackfin.uclinux.org \
    --to=rgetz@blackfin.uclinux.org \
    --cc=drow@false.org \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox