From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Daniel Jacobowitz <drow@false.org>,
Kai.Tietz@onevision.com, gdb@sourceware.org
Subject: Re: Support of gdb for Windows 64 native systems
Date: Fri, 12 Oct 2007 16:11:00 -0000 [thread overview]
Message-ID: <20071012161132.GE4044@adacore.com> (raw)
In-Reply-To: <u4pgwn2md.fsf@gnu.org>
> Actually, wouldn't it be better to separate the two completely? That
> should avoid a lot of ugly ifdefs, and make each native backend much
> cleaner, I think.
The issue with that is that we'll end up duplicating a bit of code.
In our merge, I counted 5 instances of "ifdef/ifndef __MINGW32__
in total, all of them in win32-nat.c:
- One to define MAXPATHLEN: Should really be done in a proper way,
so should go away
- One to avoid the #include <sys/procfs.h>: Should also be done
using HAVE_SYS_PROCFS_H, so should also go away
- 3 #ifdef __MINGW32__ in create_inferior to replace unix-style
IO handling with Windows-style IO handling. Can we call functions
like GetStdHandle from the cygwin compiler, or do we need the
MinGW headers for that? Perhaps the mingw code could also
work with cygwin?
The rest seems to be in i386-win32-tdep.c which is a separate file.
--
Joel
next prev parent reply other threads:[~2007-10-12 16:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071011142348.GA18239@caradoc.them.org>
2007-10-11 14:47 ` Kai Tietz
[not found] ` <20071011145549.GA19918@caradoc.them.org>
2007-10-11 16:01 ` Joel Brobecker
2007-10-12 3:38 ` Christopher Faylor
2007-10-12 4:27 ` Joel Brobecker
2007-10-11 16:37 ` Mark Kettenis
2007-10-12 7:19 ` Kai Tietz
2007-10-12 8:44 ` Eli Zaretskii
2007-10-12 16:11 ` Joel Brobecker [this message]
2007-10-12 16:51 ` Eli Zaretskii
2007-10-12 17:45 ` Joel Brobecker
2007-10-12 20:29 ` Eli Zaretskii
2007-10-12 22:28 ` Joel Brobecker
2007-10-13 2:41 ` Joel Brobecker
2007-10-13 10:48 ` Eli Zaretskii
2007-10-13 15:47 ` Joel Brobecker
2007-10-13 17:05 ` Christopher Faylor
2007-10-13 17:36 ` Pedro Alves
2007-10-13 19:09 ` Eli Zaretskii
2007-10-13 19:19 ` Pedro Alves
2007-10-13 20:51 ` Joel Brobecker
2007-10-13 22:52 ` Pedro Alves
2007-10-14 5:16 ` Joel Brobecker
2007-10-14 11:44 ` Pedro Alves
2007-10-14 20:33 ` Eli Zaretskii
2007-10-12 17:38 ` Pedro Alves
2007-10-11 13:53 Kai Tietz
2007-10-11 14:05 ` Daniel Jacobowitz
2007-10-11 14:18 ` Kai Tietz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071012161132.GE4044@adacore.com \
--to=brobecker@adacore.com \
--cc=Kai.Tietz@onevision.com \
--cc=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox