Re: Regressions on x86

[Daniel Jacobowitz <drow@false.org>]

On Tue, Jun 19, 2007 at 03:18:22PM +0200, Markus Deuling wrote:
> Daniel Jacobowitz wrote:
> > On Tue, Jun 19, 2007 at 02:37:35PM +0200, Markus Deuling wrote:
> >>> Was elfread.o linked in?  If not, what does config.log say about the
> >>> -lbfd test?
> >> bfd/elf.o was compiled. elfread.o not.
> > Then see the other part of my question :-)
> 
> 
> configure:21807: checking for ELF support in BFD
> configure:21831: gcc -o conftest -g -O2 -I/home/deuling/gdb/dev/gdb/../include 
> -I/../bfd -I/home/deuling/gdb/dev/gdb/../bfd   -L../bfd -L../libiberty 
> conftest.c -lncurses -lm  -lbfd -liberty >&5
> In file included from /home/deuling/gdb/dev/gdb/../bfd/elf-bfd.h:27,
>                 from conftest.c:133:
> /home/deuling/gdb/dev/gdb/../include/elf/external.h:248: error: syntax error 
> before "Elf_External_Versym"
> /home/deuling/gdb/dev/gdb/../include/elf/external.h:248: warning: data 
> definition has no type or storage class
> In file included from conftest.c:133:
> /home/deuling/gdb/dev/gdb/../bfd/elf-bfd.h:1459: error: syntax error before '*' 
> token
> /home/deuling/gdb/dev/gdb/../bfd/elf-bfd.h:1461: error: syntax error before 
> "Elf_External_Versym"

That is ATTRIBUTE_PACKED, which is always defined by ansidecl.h, which
is always included by bfd.h.  "-I/../bfd" is not a good sign.  It
looks like I messed up.  Please try this patch?

-- 
Daniel Jacobowitz
CodeSourcery

2007-06-19  Daniel Jacobowitz  <dan@codesourcery.com>

	* configure.ac: Do not use ${objdir}.
	* configure: Regenerated.

Index: configure
===================================================================
RCS file: /cvs/src/src/gdb/configure,v
retrieving revision 1.226
diff -u -p -r1.226 configure
--- configure	18 Jun 2007 15:46:37 -0000	1.226
+++ configure	19 Jun 2007 13:34:55 -0000
@@ -21801,7 +21801,7 @@ esac
 OLD_CFLAGS=$CFLAGS
 OLD_LDFLAGS=$LDFLAGS
 OLD_LIBS=$LIBS
-CFLAGS="$CFLAGS -I${srcdir}/../include -I${objdir}/../bfd -I${srcdir}/../bfd"
+CFLAGS="$CFLAGS -I${srcdir}/../include -I../bfd -I${srcdir}/../bfd"
 LDFLAGS="$LDFLAGS -L../bfd -L../libiberty"
 LIBS="$LIBS -lbfd -liberty"
 echo "$as_me:$LINENO: checking for ELF support in BFD" >&5
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.47
diff -u -p -r1.47 configure.ac
--- configure.ac	18 Jun 2007 15:46:38 -0000	1.47
+++ configure.ac	19 Jun 2007 13:34:55 -0000
@@ -1259,7 +1259,7 @@ AC_SUBST(WIN32LIBS)
 OLD_CFLAGS=$CFLAGS
 OLD_LDFLAGS=$LDFLAGS
 OLD_LIBS=$LIBS
-CFLAGS="$CFLAGS -I${srcdir}/../include -I${objdir}/../bfd -I${srcdir}/../bfd"
+CFLAGS="$CFLAGS -I${srcdir}/../include -I../bfd -I${srcdir}/../bfd"
 LDFLAGS="$LDFLAGS -L../bfd -L../libiberty"
 LIBS="$LIBS -lbfd -liberty"
 AC_CACHE_CHECK([for ELF support in BFD], gdb_cv_var_elf,