From: David Miller <davem@davemloft.net>
To: anton@samba.org
Cc: hpa@zytor.com, hch@infradead.org, arjan@infradead.org,
zippel@linux-m68k.org, dmlb2000@gmail.com,
linux-kernel@vger.kernel.org, gdb@sourceware.org
Subject: Re: PAGE_SIZE Availability Inconsistency
Date: Thu, 08 Mar 2007 21:48:00 -0000 [thread overview]
Message-ID: <20070308.134825.45514445.davem@davemloft.net> (raw)
In-Reply-To: <20070308214236.GA4154@kryten>
From: Anton Blanchard <anton@samba.org>
Date: Thu, 8 Mar 2007 15:42:36 -0600
> > The easiest way to fix this would be to always park the swap magic at
> > the offset of the smallest page size in use, which is 4K. This is
> > analogous how the offset for the ext2/3 superblock got fixed at 1K --
> > for 1K blocks, it's the second block, but for larger blocks, it's part
> > of the first block. If we fix the offset of the swap magic at 4096
> > minus the offset that's already there, it will always fall in the first
> > page regardless of page size.
>
> Yeah that makes sense. I gave it a go by creating a MIN_PAGE_SIZE
> define, and allowing an architecture to override it if required.
I might be missing something but doesn't this break every
SWAP partition that was created with something other than
MIN_PAGE_SIZE?
next prev parent reply other threads:[~2007-03-08 21:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9c21eeae0703051555x1884fd7cse7968a71ec04eb27@mail.gmail.com>
[not found] ` <20070306092917.GA5226@infradead.org>
[not found] ` <200703080318.04631.zippel@linux-m68k.org>
[not found] ` <20070308090031.GB7373@infradead.org>
[not found] ` <1173369229.3550.2.camel@laptopd505.fenrus.org>
2007-03-08 16:08 ` Christoph Hellwig
2007-03-08 16:22 ` Daniel Jacobowitz
2007-03-08 17:09 ` H. Peter Anvin
2007-03-08 17:12 ` Christoph Hellwig
2007-03-08 17:59 ` Anton Blanchard
2007-03-08 18:06 ` H. Peter Anvin
2007-03-08 21:44 ` Anton Blanchard
2007-03-08 21:47 ` Anton Blanchard
2007-03-08 21:48 ` David Miller [this message]
2007-03-09 2:44 ` Anton Blanchard
2007-03-09 4:20 ` H. Peter Anvin
[not found] ` <20070308.202718.68040662.davem@davemloft.net>
2007-03-09 4:32 ` H. Peter Anvin
2007-03-09 4:36 ` David Miller
2007-03-21 2:12 ` Anton Blanchard
2007-03-21 2:52 ` H. Peter Anvin
2007-03-08 22:17 ` H. Peter Anvin
2007-03-08 21:04 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070308.134825.45514445.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anton@samba.org \
--cc=arjan@infradead.org \
--cc=dmlb2000@gmail.com \
--cc=gdb@sourceware.org \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox