From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13470 invoked by alias); 18 Jun 2006 03:42:05 -0000 Received: (qmail 13462 invoked by uid 22791); 18 Jun 2006 03:42:04 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 18 Jun 2006 03:42:03 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k5I3fTDG032517; Sun, 18 Jun 2006 05:41:29 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6) with ESMTP id k5I3fSVg006871; Sun, 18 Jun 2006 05:41:28 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6/Submit) id k5I3fSHu006233; Sun, 18 Jun 2006 05:41:28 +0200 (CEST) Date: Sun, 18 Jun 2006 04:57:00 -0000 Message-Id: <200606180341.k5I3fSHu006233@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: pgilliam@us.ibm.com CC: drow@false.org, gdb@sources.redhat.com In-reply-to: <1150496761.3346.43.camel@dufur.beaverton.ibm.com> (message from PAUL GILLIAM on Fri, 16 Jun 2006 15:26:01 -0700) Subject: Re: Instrcutions that must not be stepped. References: <1149726000.10016.71.camel@dufur.beaverton.ibm.com> <20060608022654.GA31271@nevyn.them.org> <1150415676.3346.30.camel@dufur.beaverton.ibm.com> <1150496761.3346.43.camel@dufur.beaverton.ibm.com> Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00118.txt.bz2 > From: PAUL GILLIAM > Date: Fri, 16 Jun 2006 15:26:01 -0700 > > On Thu, 2006-06-15 at 16:54 -0700, PAUL GILLIAM wrote: > > I propose changing the meaning of SOFTWARE_SINGLE_STEP_P () from "This > > arch has no hardware to do single step and must use software." to "There > > may be circumstances where this arch will have to do single stepping > > with out hardware support." And make SOFTWARE_SINGLE_STEP return 1 if a > > software single step was needed and 0 if it was not. This would require > > a minor change for those arches currently using SOFTWARE_SINGLE_STEP and > > a little tweeking in "infrun.c". > > > > The only difference between doing a software single step as it is now > > and doing an "atomic single step" is how the decision of where to place > > temporary breakpoints is made. > > I have attached two diff's: "change_software_single_step.diff" makes the > change I proposed above. No you didn't :(. > I changed the name "software_single_step" to > "possibly_single_step_with_software". Hmm, I don't really see the benefit of renaming the function. I mean, that name is kinda long, and it means we get the evn longer: set_gdbarch_possibly_single_step_with_software(). By the way, if stepping these atomic sequences proves to be a performance problem, you might want to consider implementing stepping them in the (Linux) kernel. Mark