From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5119 invoked by alias); 3 Jun 2006 22:35:46 -0000 Received: (qmail 5111 invoked by uid 22791); 3 Jun 2006 22:35:46 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 03 Jun 2006 22:35:43 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FmeiX-0000v2-GR; Sat, 03 Jun 2006 18:35:37 -0400 Date: Sat, 03 Jun 2006 22:35:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Eli Zaretskii , susan@smacchia.net, jimb@codesourcery.com, gdb@sourceware.org Subject: Re: MI: -file-list-exec-source-files Message-ID: <20060603223537.GA3482@nevyn.them.org> Mail-Followup-To: Nick Roberts , Eli Zaretskii , susan@smacchia.net, jimb@codesourcery.com, gdb@sourceware.org References: <20060603004553.33821.qmail@web51812.mail.yahoo.com> <17536.58772.420434.491191@kahikatea.snap.net.nz> <17538.3165.636175.483701@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17538.3165.636175.483701@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00015.txt.bz2 On Sun, Jun 04, 2006 at 10:25:33AM +1200, Nick Roberts wrote: > > As you see, there are two entries for myproc.c and two entries for > > mytest.c, one with a NULL dirname, the other with a non-NULL dirname. > > Yes, I can see the duplicate entries But Eli's got a good point: the one with a NULL dirname is at best sub-optimal. > > Sounds like we should implement duplicate removal from the UI lists? > > I'm not sure. It may take GDB longer to remove the duplicate entries than > it does for Emacs to read them. It would be best not to create them in the > first place, but maybe that's not easily done. There are two potential sources of duplication: bugs, e.g. in our processing of symbol vs. line information, and actual duplicate entries in the debug info. As Susan correctly noted, the duplicates are often legitimate and discarding them entirely would be bad. But it sounds like the ones you're observing are the result of a bug. -- Daniel Jacobowitz CodeSourcery