Re: core regs vs. proc-service regs mess

David S. Miller
2006-04-06T20:55:59Z

From: Daniel Jacobowitz <drow@false.org>
Date: Thu, 6 Apr 2006 09:32:50 -0400

> It's .reg-xfp; created by bfd/elf.c:elfcore_grok_prxfpreg.
...
> No point testing gdbarch for NULL; it won't be. Also, I think
> gdbarch_regset_from_core_section_p is enough. If that returns NULL,
> then skip the regset. We don't need to cater to incomplete
> implementations of the core functions.
>
> Oh, and GDB prefers not to use assignments in if statements.
>
> But otherwise, yeah, this is what I had in mind. Thanks.

Thanks for the feedback.

Can I get approval for the Linux/Sparc dwarf2 bit I posted yesterday?

http://sources.redhat.com/ml/gdb-patches/2006-04/msg00065.html

I want to get that in first, then I'll finish up a final version of
these core regs changes.

Also, I haven't gotten approval for that one-liner break.exp fix
I posted the other day which we discussed in depth a few days
ago:

http://sources.redhat.com/ml/gdb-patches/2006-04/msg00051.html

If I could get an ACK or NACK on that I'd really appreciate it.

Thanks a lot!