From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12715 invoked by alias); 27 Jan 2006 16:44:44 -0000 Received: (qmail 12620 invoked by uid 22791); 27 Jan 2006 16:44:44 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 27 Jan 2006 16:44:42 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F2WiF-0003cG-SC; Fri, 27 Jan 2006 11:44:39 -0500 Date: Fri, 27 Jan 2006 17:11:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: gdb@sourceware.org Subject: Re: Prologue analysis interface Message-ID: <20060127164439.GA13699@nevyn.them.org> Mail-Followup-To: Jim Blandy , gdb@sourceware.org References: <8f2776cb0511221124u988f759u17418a114e1f3b7c@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f2776cb0511221124u988f759u17418a114e1f3b7c@mail.gmail.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00304.txt.bz2 On Tue, Nov 22, 2005 at 11:24:06AM -0800, Jim Blandy wrote: > Daniel, you said that you felt that the interface in the > prologue-value.h that I posted wasn't at the right level, and > suggested that, instead of providing types and some operations on > those types, it should instead provide the interpretation loop and > call back into tdep code to interpret specific instructions. > > Could you sketch that interface for me? I'm concerned that it will be > difficult to allow the tdep code the flexibility it needs to model the > processor without a lot of bureaucracy, but I'm willing to be > impressed. Hi Jim, I'm assuming you haven't had any time for this since we last talked about it. If that's true, how do you feel about reposting the current version of the code for review anyway? I just needed to fix a prologue analysis bug for Thumb. It took me about six hours to rewrite the prologue analyzer from scratch based on prologue-value.[ch], and it has equivalent testsuite results to the DWARF-2 unwinder; one more pass than the existing unwinder with DWARF-2 disabled; and handles the somewhat odd case that I was trying to fix without impairing anything else. It's an obvious step forwards. -- Daniel Jacobowitz CodeSourcery