From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-21028-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 15528 invoked by alias); 28 Mar 2005 14:43:13 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 15404 invoked from network); 28 Mar 2005 14:43:04 -0000
Received: from unknown (HELO sibelius.xs4all.nl) (82.92.89.47)
  by sourceware.org with SMTP; 28 Mar 2005 14:43:04 -0000
Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2])
	by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j2SEgoYP000623;
	Mon, 28 Mar 2005 16:42:50 +0200 (CEST)
Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1])
	by elgar.sibelius.xs4all.nl (8.13.3/8.13.3) with ESMTP id j2SEgn3D019564;
	Mon, 28 Mar 2005 16:42:49 +0200 (CEST)
Received: (from kettenis@localhost)
	by elgar.sibelius.xs4all.nl (8.13.3/8.13.3/Submit) id j2SEgkJs023259;
	Mon, 28 Mar 2005 16:42:46 +0200 (CEST)
Date: Mon, 28 Mar 2005 14:43:00 -0000
Message-Id: <200503281442.j2SEgkJs023259@elgar.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: dj@redhat.com
CC: ian@airs.com, gcc-patches@gcc.gnu.org, binutils@sourceware.org,
        gdb@sourceware.org
In-reply-to: <200503280235.j2S2Z4vS010751@greed.delorie.com> (message from DJ
	Delorie on Sun, 27 Mar 2005 21:35:04 -0500)
Subject: Re: [PATCH/libiberty] Add missing <sys/types.h> in unlink-if-ordinary.c
References: <200503261421.j2QEL6ll019253@elgar.sibelius.xs4all.nl>
	<16965.28989.543273.976317@cuddles.cambridge.redhat.com>
	<200503261438.j2QEcTxo024182@elgar.sibelius.xs4all.nl>
	<200503280207.j2S27WBR010185@greed.delorie.com> <m3ll88wlz5.fsf@gossamer.airs.com> <200503280235.j2S2Z4vS010751@greed.delorie.com>
X-SW-Source: 2005-03/txt/msg00255.txt.bz2

   Date: Sun, 27 Mar 2005 21:35:04 -0500
   From: DJ Delorie <dj@redhat.com>

   > <sys/types.h> is not an ISO C header file.  But it is in POSIX.1.
   > And it is available on every Unix system.  Because of that, it is
   > available on every Unix workalike system.

At least since 7th Edition Unix.

   Right, but the machines that wouldn't have it, probably would have K&R
   compilers anyway.  We haven't had a problem using it unprotected so
   far, and there's even less reason to worry about it now.

Could on of you do me the favor of checking this in on the gcc side?
Looks like I don't have write permission there anymore.  Attached is
an updated patch that also updates the copyright year.

Mark

Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* unlink-if-ordinary.c: Include <sys/types.h>.

Index: unlink-if-ordinary.c
===================================================================
RCS file: /cvs/gcc/gcc/libiberty/unlink-if-ordinary.c,v
retrieving revision 1.2
diff -u -p -r1.2 unlink-if-ordinary.c
--- unlink-if-ordinary.c 28 Mar 2005 01:28:01 -0000 1.2
+++ unlink-if-ordinary.c 28 Mar 2005 14:42:16 -0000
@@ -1,5 +1,5 @@
 /* unlink-if-ordinary.c - remove link to a file unless it is special
-   Copyright (C) 2004 Free Software Foundation, Inc.
+   Copyright (C) 2004, 2005 Free Software Foundation, Inc.
 
 This file is part of the libiberty library.  This library is free
 software; you can redistribute it and/or modify it under the
@@ -39,6 +39,8 @@ was made to unlink the file because it i
 #include "config.h"
 #endif
 
+#include <sys/types.h>
+
 #ifdef HAVE_UNISTD_H
 #include <unistd.h>
 #endif