From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26659 invoked by alias); 23 Apr 2004 18:35:28 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 26652 invoked from network); 23 Apr 2004 18:35:27 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 23 Apr 2004 18:35:27 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 774C347D63; Fri, 23 Apr 2004 11:35:27 -0700 (PDT) Date: Fri, 23 Apr 2004 22:15:00 -0000 From: Joel Brobecker To: Jim Blandy Cc: Randolph Chung , roland@redhat.com, gdb@sources.redhat.com Subject: Re: add-symbol-file-from-memory patch breaks non-elf targets? Message-ID: <20040423183527.GG2811@gnat.com> References: <20040421045817.GE17842@tausq.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i X-SW-Source: 2004-04/txt/msg00153.txt.bz2 Jim, > All right, here's a patch, tested on i686-pc-linux-gnu, > powerpc-unknown-linux-gnu, and powerpc-ibm-aix4.3.3.0. Could folks > try it out? I was able to build GDB on HPUX and tru64 with the patch applied. I also ran the testsuite, and got results that were within the ballpark figures I remember seeing for these targets. So it all looks good to me. > 2004-04-22 Jim Blandy > > Move the symbol-file-from-memory functions into their own file. > * symfile-mem.c, symfile-mem.h: New files. > * symfile.c (symbol_file_add_from_bfd): New function. > (symbol_file_add): Call symbol_file_add_from_bfd. > (symbol_file_add_from_memory, add_symbol_file_from_memory_command): > Moved to symfile-mem.c. > (_initialize_symfile): Move definition of > add-symbol-file-from-memory command to symfile-mem.c. > * symfile.h (symbol_file_add_from_bfd): New declaration. > * config/i386/linux.mt (TDEPFILES): Add symfile-mem.o. > * config/powerpc/linux.mt (TDEPFILES): Same. > * Makefile.in (SFILES): Add symfile-mem.c. > (symfile_mem_h): New variable. > (HFILES_NO_SRCDIR): Add symfile-mem.h. > (symfile-mem.o): New rule. -- Joel