From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20533 invoked by alias); 17 Feb 2004 19:33:28 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 20525 invoked from network); 17 Feb 2004 19:33:27 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 17 Feb 2004 19:33:27 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AtAyF-0008J1-2C for ; Tue, 17 Feb 2004 14:33:27 -0500 Date: Tue, 17 Feb 2004 19:33:00 -0000 From: Daniel Jacobowitz To: gdb@sources.redhat.com Subject: Re: [MI] -file-list-exec-source-files Message-ID: <20040217193327.GA31855@nevyn.them.org> Mail-Followup-To: gdb@sources.redhat.com References: <20040216033008.GB2685@nevyn.them.org> <20040216034525.GA3437@white> <20040216034930.GA29864@nevyn.them.org> <20040216153329.GA3978@white> <20040216154628.GA996@nevyn.them.org> <20040216160835.GB3978@white> <40325BC5.4090403@gnu.org> <20040217191005.GA5982@white> <20040217191238.GA30895@nevyn.them.org> <20040217193001.GB5982@white> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040217193001.GB5982@white> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-02/txt/msg00201.txt.bz2 On Tue, Feb 17, 2004 at 02:30:01PM -0500, Bob Rossi wrote: > On Tue, Feb 17, 2004 at 02:12:38PM -0500, Daniel Jacobowitz wrote: > > On Tue, Feb 17, 2004 at 02:10:05PM -0500, Bob Rossi wrote: > > > I have one last question that didn't get answered, could the psymtab be > > > modified to contain the dirname? > > > > Probably, but the dirname -> fullname conversion may be expensive - it > > involves a lot of stat() calls. > > I could definatly use some advice getting the dirname into the psymtab. > I don't mind spending time implementing it if I could get a little > pointer in the right direction. It seems I would have to change both the > stabs reader and the dwarf2 reader. Is that correct? Yes, I think so. Dwarf2 should be easy. Stabs will be a little harder. Take a look at patch_subfile_names. > I don't think the dirname->fullname conversion is bad at all. Well, at > least relative to looking up the fullname without the dirname. > > Either, you lookup the fullname without the dirname, by using openp, > which has say N lookup attempts ( N-1 dir search path entries + 1 > entry for the cwd ) > or > you lookup the fullname with dirname, by using open_source_file, which > add's 1 to that value of N ( by putting dirname in front ), and then > calls openp. > > So, I think looking up the fullname with or without knowing the dirname > yeilds the same magnitude of work. However, if openp is implemented poorly, > I could also look into that. My point was not that one of these would be pricier than the other, but that they are both pricy. For a large application, doing this conversion for all files will substantially penalize your startup time. Not to mention having to redo most of it when a new dir is added... -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer