From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6857 invoked by alias); 22 Jan 2004 18:48:19 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 6841 invoked from network); 22 Jan 2004 18:48:17 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 22 Jan 2004 18:48:17 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AjjsH-0008OP-Aa; Thu, 22 Jan 2004 13:48:17 -0500 Date: Thu, 22 Jan 2004 18:48:00 -0000 From: Daniel Jacobowitz To: gcc-patches@gcc.gnu.org, gdb@sources.redhat.com Cc: Richard Henderson Subject: Re: RFA: Line number fix for prologues Message-ID: <20040122184816.GA32235@nevyn.them.org> Mail-Followup-To: gcc-patches@gcc.gnu.org, gdb@sources.redhat.com, Richard Henderson References: <20040116153601.GA28489@nevyn.them.org> <20040116201238.GD26740@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040116201238.GD26740@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-01/txt/msg00252.txt.bz2 On Fri, Jan 16, 2004 at 12:12:38PM -0800, Richard Henderson wrote: > On Fri, Jan 16, 2004 at 10:36:01AM -0500, Daniel Jacobowitz wrote: > > My silly question is, does that emit_nop () even serve any purpose? I > > imagine it was there to make the loop optimizer happy once upon a time ... > > Actually, I think it's for debugging. Certainly the loop optimizer > won't care one way or the other. If you can show that gdb works as > well or better without that nop (both dwarf and stabs) then I think > that's ample reason to remove it. In that case, this OK for HEAD and 3.4? The only repeatable test differences were the fixed failures in break.exp/sepdebug.exp that I mentioned earlier. Tested via the gdb testsuite, dwarf and stabs. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2004-01-22 Daniel Jacobowitz * c-semantics.c (genrtl_while_stmt, genrtl_do_stmt_1) (genrtl_for_stmt): Remove emit_nop calls. Index: c-semantics.c =================================================================== RCS file: /big/fsf/rsync/gcc-cvs/gcc/gcc/c-semantics.c,v retrieving revision 1.74 diff -u -p -r1.74 c-semantics.c --- c-semantics.c 24 Nov 2003 20:12:06 -0000 1.74 +++ c-semantics.c 16 Jan 2004 15:27:32 -0000 @@ -430,7 +430,6 @@ genrtl_while_stmt (tree t) { tree cond = WHILE_COND (t); - emit_nop (); emit_line_note (input_location); expand_start_loop (1); genrtl_do_pushlevel (); @@ -467,7 +466,6 @@ genrtl_do_stmt_1 (tree cond, tree body) } else if (integer_nonzerop (cond)) { - emit_nop (); emit_line_note (input_location); expand_start_loop (1); @@ -478,7 +476,6 @@ genrtl_do_stmt_1 (tree cond, tree body) } else { - emit_nop (); emit_line_note (input_location); expand_start_loop_continue_elsewhere (1); @@ -542,7 +539,6 @@ genrtl_for_stmt (tree t) expand_stmt (FOR_INIT_STMT (t)); /* Expand the initialization. */ - emit_nop (); emit_line_note (input_location); if (FOR_EXPR (t)) expand_start_loop_continue_elsewhere (1);