From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26154 invoked by alias); 16 Jan 2004 20:12:41 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 26058 invoked from network); 16 Jan 2004 20:12:40 -0000 Received: from unknown (HELO frothingslosh.sfbay.redhat.com) (66.187.237.200) by sources.redhat.com with SMTP; 16 Jan 2004 20:12:40 -0000 Received: from frothingslosh.sfbay.redhat.com (localhost.localdomain [127.0.0.1]) by frothingslosh.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id i0GKCdOG027202; Fri, 16 Jan 2004 12:12:39 -0800 Received: (from rth@localhost) by frothingslosh.sfbay.redhat.com (8.12.8/8.12.8/Submit) id i0GKCdhA027200; Fri, 16 Jan 2004 12:12:39 -0800 X-Authentication-Warning: frothingslosh.sfbay.redhat.com: rth set sender to rth@redhat.com using -f Date: Fri, 16 Jan 2004 20:12:00 -0000 From: Richard Henderson To: gcc-patches@gcc.gnu.org, gdb@sources.redhat.com Subject: Re: RFA: Line number fix for prologues Message-ID: <20040116201238.GD26740@redhat.com> Mail-Followup-To: Richard Henderson , gcc-patches@gcc.gnu.org, gdb@sources.redhat.com References: <20040116153601.GA28489@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040116153601.GA28489@nevyn.them.org> User-Agent: Mutt/1.4i X-SW-Source: 2004-01/txt/msg00212.txt.bz2 On Fri, Jan 16, 2004 at 10:36:01AM -0500, Daniel Jacobowitz wrote: > My silly question is, does that emit_nop () even serve any purpose? I > imagine it was there to make the loop optimizer happy once upon a time ... Actually, I think it's for debugging. Certainly the loop optimizer won't care one way or the other. If you can show that gdb works as well or better without that nop (both dwarf and stabs) then I think that's ample reason to remove it. > * final.c (SEEN_BB, SEEN_NOTE, SEEN_EMITTED): Define. > (final_scan_insn): Update to take an additional SEEN argument. Emit > a line note after the prologue. Make static. > (line_note_exists): Remove. > (final): Don't initialize line_note_exists. Update call to > final_scan_insn. > * output.h (final_scan_insn): Remove prologue. > * function.c (set_insn_locators): Update comment. > (thread_prologue_and_epilogue_insns): Add a comment. Ok. r~