From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-16280-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 2081 invoked by alias); 21 Nov 2003 07:55:39 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 2074 invoked from network); 21 Nov 2003 07:55:38 -0000
Received: from unknown (HELO disaster.jaj.com) (24.123.75.82)
  by sources.redhat.com with SMTP; 21 Nov 2003 07:55:38 -0000
Received: from disaster.jaj.com (localhost.localhost [127.0.0.1])
	by disaster.jaj.com (8.12.10/8.12.9) with ESMTP id hAL7tWhM013626;
	Fri, 21 Nov 2003 02:55:32 -0500
Received: (from phil@localhost)
	by disaster.jaj.com (8.12.10/8.12.9/Submit) id hAL7tWAw013625;
	Fri, 21 Nov 2003 02:55:32 -0500
Date: Fri, 21 Nov 2003 07:55:00 -0000
From: Phil Edwards <phil@jaj.com>
To: gdb@sources.redhat.com, cagney@redhat.com
Subject: Your change breaks GDB for ARM
Message-ID: <20031121075532.GA13535@disaster.jaj.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.4i
X-SW-Source: 2003-11/txt/msg00187.txt.bz2

(I am not subscribed to this list.)


This change

  2003-11-13  Andrew Cagney  <cagney@redhat.com>

    * arch-utils.h (selected_architecture_name): Declare.
    (selected_byte_order): Declare.
    * arch-utils.c (selected_byte_order): New function.
    (selected_architecture_name): New function.
    (target_architecture_auto): Make static.
    (set_architecture_string): Make static.
    (target_byte_order): Make static.
    (target_byte_order_auto): Make static.
    * gdbarch.sh (TARGET_BYTE_ORDER, TARGET_ARCHITECTURE): Delete
    non-multi-arch definition.
    (TARGET_ARCHITECTURE_AUTO, TARGET_BYTE_ORDER_AUTO): Delete.
    (target_byte_order, target_architecture): Delete declaration.
    (target_byte_order_auto, target_architecture_auto): Ditto.
    * gdbarch.h: Re-generate.
    * remote-sim.c (gdbsim_open): Use "selected_architecture_name" and
    "selected_byte_order".

didn't get enough testing.  As a trivial search shows,

    fenric 57% cd gdb
    fenric 58% grep -l target_byte_order *.c
    arch-utils.c
    remote-rdp.c
    fenric 59%

this variable is still being used outside of the file where you made
it static, and now GDB will not build for arm-elf targets, which use
remote-rdp.c.

I looked very briefly at the new code, but as remote-rdp.c is setting
target_byte_order, not reading it, there is no obvious change I could make.
Please fix this breakage soon.


Phil